Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable Rebuild] [Controls] Fix apply button style bugs #189433

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[Embeddable Rebuild] [Controls] Fix apply button style bugs #189433

merged 1 commit into from
Jul 30, 2024

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Jul 29, 2024 •
edited
Loading

Closes #189303

Summary

Note

This PR has no user-facing changes - all work is contained in the examples plugin.

This fixes the placement of both the time slider play button and the control group apply button:

Before After
image image

It also removes the tooltip when the apply button is enabled - this is due to a known EUI bug where the tooltip gets stuck when a button switches from "enabled" to "disabled" (and vice versa).

Checklist

  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Controls project:embeddableRebuild labels Jul 29, 2024
@Heenawter Heenawter self-assigned this Jul 29, 2024
@Heenawter
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

@Heenawter Heenawter marked this pull request as ready for review July 29, 2024 19:04
@Heenawter Heenawter requested review from a team as code owners July 29, 2024 19:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

nreese
nreese approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@Heenawter Heenawter merged commit 6c581d5 into elastic:main Jul 30, 2024
33 checks passed
@Heenawter Heenawter deleted the embeddableRebuild_controls_fix-style-bugs_2024-07-29 branch July 30, 2024 19:21
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees

@Heenawter Heenawter

Labels
backport:skip This commit does not require backporting impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Controls project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Embeddable Rebuild] [Controls] Style bugs when apply button is enabled
6 participants
@Heenawter @kibana-ci @elasticmachine @nreese @ryankeairns @kibanamachine