[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel #188664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
release_note:fix
Team:Visualizations
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
|
mbondyra
force-pushed
the
lens/fix_breaking_flyout
branch
from
e583c70 to
5c42edc
Compare
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
nickofthyme
approved these changes
Jul 19, 2024
Contributor
nickofthyme
left a comment
nickofthyme
left a comment
There was a problem hiding this comment.
Confirms this fixes issue 👍🏼
|
|
||
| function SecondaryMetricEditor({ accessor, idPrefix, frame, layerId, setState, state }: SubProps) { | ||
| const columnName = getColumnByAccessor(accessor, frame.activeData?.[layerId].columns)?.name; | ||
| const columnName = getColumnByAccessor(accessor, frame.activeData?.[layerId]?.columns)?.name; |
Contributor
There was a problem hiding this comment.
Nice! This is why we enabled noUncheckedIndexedAccess in @elastic/charts elastic/elastic-charts#2006.
That way any array access is treated as a union with undefined unless the type is an explicit tuple.
Contributor
Author
There was a problem hiding this comment.
Good idea! It'd be good to add it in Kibana, we had some bugs in the past caused by it.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 22, 2024
…lastic#188664) ## Summary Fixes elastic#184544 (cherry picked from commit b7b3260)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 22, 2024
… panel (#188664) (#188857) # Backport This will backport the following commits from `main` to `8.15`: - [[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel (#188664)](#188664) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-07-22T14:59:40Z","message":"[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel (#188664)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/184544","sha":"b7b3260db2b150911f283351655a721d7f16e711","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:prev-minor","v8.16.0"],"title":"[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel","number":188664,"url":"https://github.com/elastic/kibana/pull/188664","mergeCommit":{"message":"[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel (#188664)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/184544","sha":"b7b3260db2b150911f283351655a721d7f16e711"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188664","number":188664,"mergeCommit":{"message":"[Dashboard][ES|QL] Unable to load page error on edit/add ES|QL panel (#188664)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/184544","sha":"b7b3260db2b150911f283351655a721d7f16e711"}}]}] BACKPORT--> Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #184544