Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [CI] Fix publish script (#188027) #188444

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Jul 16, 2024

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

## Summary
Another attempt to fix the DRY_RUN-enhanced publish call - as it seems
simply emitting the script only works if there are no arguments.

Fixes:
https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4488#01909cf6-71a4-4608-a830-041af9d781d9
Tested here:
https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4490 (the
dry-run is supposedly added? but it seems the artifacts were published
nonetheless - at least there's no more syntax error)

Succesful run with the if-else:
https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4516

(cherry picked from commit 9d75f32)

# Conflicts:
#	.buildkite/scripts/steps/artifacts/publish.sh
@delanni delanni enabled auto-merge (squash) July 16, 2024 14:33
@delanni delanni disabled auto-merge July 16, 2024 14:39
@delanni
Copy link
Contributor Author

delanni commented Jul 16, 2024

Foregoing approval, it's a direct backport

@delanni delanni merged commit b2990f4 into elastic:8.15 Jul 16, 2024
8 of 12 checks passed
@delanni delanni deleted the backport/8.15/pr-188027 branch July 16, 2024 14:39
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants