Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BK] Migrate the kibana-on-merge job #184391

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented May 29, 2024

Summary

This PR adds the pipeline resource definition and adjusts the agent targeting rules for the kibana-on-merge job.

Migration staging runs:

8.14: #184513
7.17: #184497

@delanni delanni changed the title chore(BK): Migrate the kibana-on-merge job [BK] Migrate the kibana-on-merge job May 30, 2024
@delanni delanni added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting ci:all-cypress-suites labels Jun 4, 2024
@delanni delanni marked this pull request as ready for review June 5, 2024 16:18
@delanni delanni requested a review from a team as a code owner June 5, 2024 16:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

REPORT_FAILED_TESTS_TO_GITHUB: 'true'
ELASTIC_SLACK_NOTIFICATIONS_ENABLED: 'true'
allow_rebuilds: true
branch_configuration: main 7.17 8.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want all 8.x branches. Many of them aren't going to build, e.g. #167153.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same, but wouldn't the pipeline only run if there was a merge into an old branch? Which shouldn't happen anyways?

Copy link
Member

@jbudz jbudz Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does happen, documentation is still builtsourced off old branches and fixes will be backported all the way back. example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, but then this still remains as something we'll need to update manually on minor bumps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we add several future versions up front, and just remove a few every now and then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to update it anyways for periodic pipelines, would adding future versions help much?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's this attempt to try to do something about these pipelines that would depend on the supported versions:
#184018

This one avoids templates, but that would be the universal solution, I believe, if we need to factor these cases in

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit b5af943 into elastic:main Jun 11, 2024
17 checks passed
@delanni delanni deleted the migrate-kibana-on-merge branch June 11, 2024 08:08
delanni added a commit that referenced this pull request Jun 11, 2024
## Summary
Backport of #184391 to 8.14

Migration staging runs:
-
https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/119
-
https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/122

Was flaky on Cypress tests, but after a retry it went away. Maybe it's
the usual cypress flakiness?
delanni added a commit that referenced this pull request Jun 12, 2024
## Summary
Backport of #184391 to 8.13

Test run successful, outside of a widely failing flaky FTR:
https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants