[Fleet] Add support_agentless property in agent policy schema and preconfiguration #182709

criamico · 2024-05-06T15:05:09Z

Summary

Add a new support_agentless property in agent policy and in preconfiguration; this property is only allowed when the environment has both isServerless set to true and agentless feature flag enabled, otherwise policy creation/update will throw error supports_agentless is only allowed in serverless environments that support agentless feature.

No UI change is required for now as this property will be needed as part of a wider support to agentless policies.

Testing

Serverless

Run serverless env configured for agentless following this guide
Make sure to have agentless feature flag enabled
Create an agent policy with support_agentless property:

POST kbn:/api/fleet/agent_policies
{
  "name": "New agent policy",
  "namespace": "default",
  "supports_agentless": true
}

Update an existing agent policy with the new property:

PUT kbn:/api/fleet/agent_policies/<opolicy_id>
{
  "name": "New agent policy",
  "supports_agentless": true
}

Create a preconfigured agent policy in kibana.dev.yml, and verify it that it's correct via GET kbn:/api/fleet/agent_policies:

xpack.fleet.agentPolicies: [
  {
    "name": "Agentless Policy",
    "id": "agentless",
    "is_managed": true,
    "namespace": "default",
    "supports_agentless": true,
  },
]

Note that if agentless feature flag is disabled, any of the above will throw an error.

Stateful

Spin up a stateful env and verify that all of the previous commands fail with 400 and above error message.

Checklist

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

…configuration

apmmachine · 2024-05-06T15:05:26Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

criamico · 2024-05-06T15:05:40Z

/ci

…te --fix'

criamico · 2024-05-06T16:06:08Z

/ci

… src/core/server/integration_tests/ci_checks'

criamico · 2024-05-07T08:11:11Z

@elasticmachine merge upstream

criamico · 2024-05-07T08:35:59Z

/ci

elasticmachine · 2024-05-07T13:53:50Z

Pinging @elastic/fleet (Team:Fleet)

criamico · 2024-05-07T13:55:29Z

PR needed in preparation for #180375. I originally thought to group the changes in a single PR but the changeset would become too big.

x-pack/plugins/fleet/common/openapi/bundled.json

x-pack/plugins/fleet/common/openapi/bundled.yaml

x-pack/plugins/fleet/common/openapi/components/schemas/agent_policy.yaml

kilfoyle

LGTM for the docs part. 👍

kpollich

Code + tests LGTM. Thanks for splitting this up into separate PR's 🚀

x-pack/plugins/fleet/server/services/agent_policy.ts

x-pack/plugins/fleet/server/services/preconfiguration.ts

afharo

SO mapping changes LGTM

kc13greiner

LGTM!

criamico · 2024-05-08T07:51:11Z

@elasticmachine merge upstream

kibana-ci · 2024-05-08T08:57:40Z

💚 Build Succeeded

Buildkite Build
Commit: d4607fa

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1179	1180	+1

Unknown metric groups

API count

id	before	after	diff
`fleet`	1300	1301	+1

History

💚 Build #208324 succeeded 0f1150d
💔 Build #208213 failed 30111b5
💔 Build #208196 failed adee962

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

Closes #180375 ## Summary Expand support for Agentless in Fleet UI. Implemented on this PR: - Agent policies created with `supports_agentless` (added in #182709) are now marked as `is_managed` - Added support for `deployment_modes.agentless.enabled` and `hide_in_deployment_modes` introduced with elastic/package-spec#684: - `hide_in_deployment_modes` shows/hides variables in agentless/default UI - `deployment_modes.agentless.enabled: true` determines an integration as enabled for agentless ## Notes - In this PR, an integration enabled for serverless is still added to the default `agentless` policy. - Integrations enabled for agentless don't display any specific "agentless" form yet. That part is TBD ### Testing - Run local env for [agentless](https://docs.elastic.dev/security-solution/cloud-security/agentless) ### Verify that new settings are honoured in integration policy - Use the compiled package with new properties defined in elastic/package-spec#738 `agentless_test_package-1.0.1-rc1.zip` (Packages in this [comment](#183045 (comment))) - Upload it to Kibana: ```sh curl -k -XPOST -H 'content-type: application/zip' -H 'kbn-xsrf: true' https://localhost:5601/api/fleet/epm/packages -u elastic_serverless:changeme --data-binary @agentless_test_package-0.0.1.zip ``` - Check that the variable marked with `hide_in_deployment_modes: "agentless"` are not visible - Check that the agent policies selector is not visible ![Screenshot 2024-05-22 at 10 37 42](https://github.com/elastic/kibana/assets/16084106/02f12ebf-f448-4cfa-b9e7-8cb1a1226e5e) ### Verify that agent policies with `supports_agentless` are marked as managed - Create a new policy with `supports_agentless` ``` POST kbn:/api/fleet/agent_policies { "name": "Test - Agentless policy", "namespace": "default", "supports_agentless": true } ``` - Check that the created policy has `is_managed = true` - Try to change the value to false - an error is thrown ``` PUT kbn:/api/fleet/agent_policies/<policy_id> { "name": "Test - Agentless policy", "namespace": "default", "supports_agentless": false } ``` ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Fleet] Add support_agentless property in agent policy schema and pre…

adee962

…configuration

criamico self-assigned this May 6, 2024

criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label May 6, 2024

criamico added the v8.15.0 label May 6, 2024

criamico added the release_note:skip Skip the PR/issue when compiling release notes label May 6, 2024

criamico and others added 2 commits May 6, 2024 17:13

Modify openapi

e3826d1

[CI] Auto-commit changed files from 'node scripts/check_mappings_upda…

30111b5

…te --fix'

kibanamachine and others added 2 commits May 6, 2024 16:41

[CI] Auto-commit changed files from 'node scripts/jest_integration -u…

9616fae

… src/core/server/integration_tests/ci_checks'

Fix mapping test

def96f0

Merge branch 'main' into 180377_Add_support_agentless_property

0f1150d

criamico added 2 commits May 7, 2024 14:45

Merge main and fix merge conflicts

26efbdd

Add agentless feature flag guard

d5e03e6

criamico marked this pull request as ready for review May 7, 2024 13:53

criamico requested review from a team as code owners May 7, 2024 13:53

kc13greiner self-requested a review May 7, 2024 15:27

kilfoyle reviewed May 7, 2024

View reviewed changes

x-pack/plugins/fleet/common/openapi/bundled.json Outdated Show resolved Hide resolved

kilfoyle reviewed May 7, 2024

View reviewed changes

x-pack/plugins/fleet/common/openapi/bundled.yaml Outdated Show resolved Hide resolved

kilfoyle reviewed May 7, 2024

View reviewed changes

x-pack/plugins/fleet/common/openapi/components/schemas/agent_policy.yaml Outdated Show resolved Hide resolved

kilfoyle approved these changes May 7, 2024

View reviewed changes

kpollich approved these changes May 7, 2024

View reviewed changes

x-pack/plugins/fleet/server/services/agent_policy.ts Outdated Show resolved Hide resolved

x-pack/plugins/fleet/server/services/preconfiguration.ts Outdated Show resolved Hide resolved

afharo approved these changes May 7, 2024

View reviewed changes

kc13greiner approved these changes May 7, 2024

View reviewed changes

Address code review comments

ed34c77

Merge branch 'main' into 180377_Add_support_agentless_property

d4607fa

criamico merged commit eb5e329 into elastic:main May 8, 2024
20 checks passed

kibanamachine added the backport:skip This commit does not require backporting label May 8, 2024

criamico deleted the 180377_Add_support_agentless_property branch May 8, 2024 08:58

criamico mentioned this pull request May 9, 2024

[Fleet] Update Fleet UI to handle agentless integrations + policies #180375

Closed

3 tasks

criamico mentioned this pull request May 21, 2024

[Fleet] Improve support for Agentless in Fleet UI #183045

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Add support_agentless property in agent policy schema and preconfiguration #182709

[Fleet] Add support_agentless property in agent policy schema and preconfiguration #182709

criamico commented May 6, 2024 •

edited

Loading

apmmachine commented May 6, 2024

criamico commented May 6, 2024

criamico commented May 6, 2024

criamico commented May 7, 2024

criamico commented May 7, 2024

elasticmachine commented May 7, 2024

criamico commented May 7, 2024

kilfoyle left a comment

kpollich left a comment

afharo left a comment

kc13greiner left a comment

criamico commented May 8, 2024

kibana-ci commented May 8, 2024

API count

[Fleet] Add support_agentless property in agent policy schema and preconfiguration #182709

[Fleet] Add support_agentless property in agent policy schema and preconfiguration #182709

Conversation

criamico commented May 6, 2024 • edited Loading

Summary

Testing

Serverless

Stateful

Checklist

apmmachine commented May 6, 2024

🤖 GitHub comments

criamico commented May 6, 2024

criamico commented May 6, 2024

criamico commented May 7, 2024

criamico commented May 7, 2024

elasticmachine commented May 7, 2024

criamico commented May 7, 2024

kilfoyle left a comment

Choose a reason for hiding this comment

kpollich left a comment

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

kc13greiner left a comment

Choose a reason for hiding this comment

criamico commented May 8, 2024

kibana-ci commented May 8, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

API count

History

criamico commented May 6, 2024 •

edited

Loading