Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Ftr API Integration tests #182626

Merged
merged 2 commits into from
May 6, 2024
Merged

[Security] Ftr API Integration tests #182626

merged 2 commits into from
May 6, 2024

Conversation

dkirchan
Copy link
Contributor

@dkirchan dkirchan commented May 4, 2024

Summary

Try catch statement in the PR for the API Ftr Integration tests, introduced a cover above the target fix of the specific PR.

The tests were failing however the exit code was still 0 so the failures are hidden. This PR addresses the specific issue.

@dkirchan dkirchan added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0 labels May 4, 2024
@dkirchan dkirchan self-assigned this May 4, 2024
@dkirchan dkirchan requested a review from a team as a code owner May 4, 2024 12:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@dkirchan dkirchan requested a review from a team May 4, 2024 12:18
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dkirchan

@dkirchan dkirchan changed the title Security ftr fix [Security] Ftr API Integration tests May 6, 2024
@MadameSheema MadameSheema enabled auto-merge (squash) May 6, 2024 07:38
@MadameSheema MadameSheema merged commit 1303295 into main May 6, 2024
26 checks passed
@MadameSheema MadameSheema deleted the security-ftr-fix branch May 6, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants