[Console] Implement documentation action button #181057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
Feature:Console
yuliacech
added
the
release_note:skip
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
botelastic
bot
added
the
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
smith
removed
the
Team:obs-ux-infra_services
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ElenaStoeva
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Great work @yuliacech! Tested locally and it works as expected. Code changes also LGTM.
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #180209
This PR implements the "view documentation" button in the new Monaco editor in Console. The code re-use the existing autocomplete functionality and gets the documentation link for the current request from autocomplete definitions. The current request is the 1st request of the user selection in the editor. The link is opened in the new tab and if no link is available or the request is unknown, then nothing happens (existing functionality, we might want to hide the button in that case in a follow up work)
Screen recording
Screen.Recording.2024-04-17.at.17.04.42.mov
How to test
console.dev.enableMonaco: trueto theconfig/kibana.dev.ymlfile