Skip to content

[Lens] Cleanups the veil flag from the ExpressionWrapper #176363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

[Lens] Cleanups the veil flag from the ExpressionWrapper #176363

merged 1 commit into from
Feb 7, 2024

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Feb 7, 2024

Summary

Cleanups the unused shouldUseSizeTransitionVeil from the ExpressionWrapper. This true default value can cause bugs in embeddables.

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting v8.13.0 labels Feb 7, 2024
@stratoula stratoula changed the title [Lens] Cleanup the veil flag from the ExpressionWrapper [Lens] Cleanups the veil flag from the ExpressionWrapper Feb 7, 2024
@stratoula stratoula requested a review from drewdaemon February 7, 2024 06:48
@stratoula stratoula marked this pull request as ready for review February 7, 2024 06:48
@stratoula stratoula requested a review from a team as a code owner February 7, 2024 06:48
@stratoula stratoula added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Feb 7, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 7, 2024

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula
Copy link
Contributor Author

stratoula commented Feb 7, 2024

/ci

@kibana-ci
Copy link

kibana-ci commented Feb 7, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #41 / aiops log rate analysis with 'kibana_sample_data_logstsdb' kibana sample data logs displays index details
  • [job] [logs] FTR Configs #86 / discover/group2 discover data grid tests "before all" hook for "can add fields to the table"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB -69.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

drewdaemon
drewdaemon approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stratoula stratoula merged commit e9e7304 into elastic:main Feb 7, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 8, 2024
@stratoula @fkanout
[Lens] Cleanups the veil flag from the ExpressionWrapper (elastic#176363
db55775 
)

## Summary

Cleanups the unused shouldUseSizeTransitionVeil from the
ExpressionWrapper. This true default value can cause bugs in
embeddables.
@stratoula stratoula mentioned this pull request Feb 13, 2024
Closed
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@stratoula @CoenWarmer
[Lens] Cleanups the veil flag from the ExpressionWrapper (elastic#176363
9d80bde 
)

## Summary

Cleanups the unused shouldUseSizeTransitionVeil from the
ExpressionWrapper. This true default value can cause bugs in
embeddables.
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@stratoula @fkanout
[Lens] Cleanups the veil flag from the ExpressionWrapper (elastic#176363
6e67703 
)

## Summary

Cleanups the unused shouldUseSizeTransitionVeil from the
ExpressionWrapper. This true default value can cause bugs in
embeddables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stratoula @elasticmachine @kibana-ci @drewdaemon