Skip to content

[Onboarding] guide card css changes #176338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2024
Merged

[Onboarding] guide card css changes #176338

merged 3 commits into from
Feb 7, 2024

Conversation

@rshen91
Copy link
Contributor

@rshen91 rshen91 commented Feb 6, 2024 •
edited
Loading

Summary

Closes #168401
This PR supports two line titles in guide cards when the guide complete badge appears it isn't cut by the border of the card.

Screenshot 2024-02-06 at 1 50 27 PM Screenshot 2024-02-06 at 1 50 42 PM

@rshen91 rshen91 self-assigned this Feb 6, 2024
@rshen91 rshen91 requested review from a team and Casper-DB and removed request for Casper-DB February 6, 2024 18:24
@rshen91 rshen91 added the release_note:skip Skip the PR/issue when compiling release notes label Feb 6, 2024
@petrklapka
Copy link
Member

petrklapka commented Feb 6, 2024

Screenshot?

@rshen91 rshen91 marked this pull request as ready for review February 6, 2024 20:52
@rshen91 rshen91 requested a review from a team as a code owner February 6, 2024 20:52
@rshen91 rshen91 added the Team:Journey/Onboarding Platform Journey Onboarding team label Feb 6, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 6, 2024

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

bollinic
bollinic approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@bollinic bollinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rshen91 rshen91 enabled auto-merge (squash) February 7, 2024 14:13
@kibana-ci
Copy link

kibana-ci commented Feb 7, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #51 / aiops log rate analysis with 'kibana_sample_data_logstsdb' kibana sample data logs displays index details
  • [job] [logs] FTR Configs #92 / Observability Rules Rules Endpoints Custom Threshold rule RATE - GROUP_BY - BYTES - FIRED Rule creation should set correct action variables
  • [job] [logs] Jest Tests #5 / Severity form field renders
  • [job] [logs] Jest Tests #5 / Severity form field selects the correct value when changed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 137.7KB 137.7KB -78.0B
securitySolution 11.4MB 11.4MB +6.4KB
securitySolutionServerless 177.4KB 183.7KB +6.3KB
total +12.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

@rshen91 rshen91 merged commit 74aad4f into elastic:main Feb 7, 2024
@kibanamachine kibanamachine added v8.13.0 backport:skip This PR does not require backporting labels Feb 7, 2024
@rshen91 rshen91 deleted the onboarding-card-design branch February 7, 2024 16:20
fkanout pushed a commit to fkanout/kibana that referenced this pull request Feb 8, 2024
@rshen91 @fkanout
[Onboarding] guide card css changes (elastic#176338)
3b3a70a 
## Summary
Closes elastic#168401
This PR supports two line titles in guide cards when the guide complete
badge appears it isn't cut by the border of the card.

<img width="1613" alt="Screenshot 2024-02-06 at 1 50 27 PM"
src="https://github.com/elastic/kibana/assets/20343860/6fac3a2e-a174-4b6c-b38e-1f396fa3ba21">
<img width="479" alt="Screenshot 2024-02-06 at 1 50 42 PM"
src="https://github.com/elastic/kibana/assets/20343860/8ac146fb-a763-4651-9588-a6246933631a">
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@rshen91 @CoenWarmer
[Onboarding] guide card css changes (elastic#176338)
74676e8 
## Summary
Closes elastic#168401
This PR supports two line titles in guide cards when the guide complete
badge appears it isn't cut by the border of the card.

<img width="1613" alt="Screenshot 2024-02-06 at 1 50 27 PM"
src="https://github.com/elastic/kibana/assets/20343860/6fac3a2e-a174-4b6c-b38e-1f396fa3ba21">
<img width="479" alt="Screenshot 2024-02-06 at 1 50 42 PM"
src="https://github.com/elastic/kibana/assets/20343860/8ac146fb-a763-4651-9588-a6246933631a">
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@rshen91 @fkanout
[Onboarding] guide card css changes (elastic#176338)
e9da7a1 
## Summary
Closes elastic#168401
This PR supports two line titles in guide cards when the guide complete
badge appears it isn't cut by the border of the card.

<img width="1613" alt="Screenshot 2024-02-06 at 1 50 27 PM"
src="https://github.com/elastic/kibana/assets/20343860/6fac3a2e-a174-4b6c-b38e-1f396fa3ba21">
<img width="479" alt="Screenshot 2024-02-06 at 1 50 42 PM"
src="https://github.com/elastic/kibana/assets/20343860/8ac146fb-a763-4651-9588-a6246933631a">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bollinic bollinic bollinic approved these changes

Assignees

@rshen91 rshen91

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Onboarding] Guide status falls outside of guide card

6 participants

@rshen91 @petrklapka @elasticmachine @kibana-ci @bollinic @kibanamachine