Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock package manager version #175495

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Lock package manager version #175495

merged 7 commits into from
Jan 26, 2024

Conversation

jacoblee93
Copy link
Contributor

@jacoblee93 jacoblee93 commented Jan 24, 2024 •
edited by kibanamachine
Loading

Summary

I believe the intention was to restrict the yarn version to 1.22.19, but the current package.json setup does not enforce it. This config change should do it.

Checklist

None.

Risk Matrix

None.

For maintainers

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Jan 24, 2024 •
edited
Loading

💚 CLA has been signed

@jacoblee93
Copy link
Contributor Author

Signed!

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes v8.13.0 Team:Operations Team label for Operations Team labels Jan 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, thanks for opening this.

package.json Outdated Show resolved Hide resolved
@jacoblee93 @jbudz
Update package.json
15b8e8c 
Co-authored-by: Jon <jon@budzenski.me>
@jbudz
Copy link
Member

jbudz commented Jan 25, 2024

buildkite test this

@jbudz
Copy link
Member

jbudz commented Jan 25, 2024

@elasticmachine run elasticsearch-ci/docs

@jbudz jbudz added the backport:all-open Backport to all branches that could still receive a release label Jan 25, 2024
jbudz
jbudz reviewed Jan 25, 2024
View reviewed changes
package.json Outdated
@@ -1681,5 +1681,6 @@
"xmlbuilder": "13.0.2",
"yargs": "^15.4.1",
"yarn-deduplicate": "^6.0.2"
}
},
"packageManager": "^yarn@1.22.19"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, it looks like I was mistaken and the ^ is not used. We're running 1.22.21 on CI, do you mind if we update the versions to 1.22.21 and remove the ^?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all! I can do it too

@jbudz
Copy link
Member

jbudz commented Jan 25, 2024

buildkite test this

@jbudz
Copy link
Member

jbudz commented Jan 25, 2024

@elasticmachine run elasticsearch-ci/docs

@jbudz jbudz mentioned this pull request Jan 25, 2024
Merged
jbudz added a commit that referenced this pull request Jan 25, 2024
@jbudz
Upgrade yarn to 1.22.21 in WORKSPACE.bazel (#175632)
81ae390 
In addition to #175495
@jbudz
Copy link
Member

jbudz commented Jan 25, 2024

buildkite test this

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 25, 2024
@jbudz
Upgrade yarn to 1.22.21 in WORKSPACE.bazel (elastic#175632)
b07aba2 
In addition to elastic#175495

(cherry picked from commit 81ae390)
jbudz
jbudz reviewed Jan 25, 2024
View reviewed changes
package.json Outdated
Comment on lines 1688 to 1689
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all the issues! I think this is the last one - bootstrap is removing the trailing newline here and we have a modified files check that's failing. Can we remove the newline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

jbudz added a commit to jbudz/kibana that referenced this pull request Jan 25, 2024
@jbudz
Upgrade yarn to 1.22.21 in WORKSPACE.bazel (elastic#175632)
ee40a02 
In addition to elastic#175495
kibanamachine referenced this pull request Jan 25, 2024
@kibanamachine @jbudz
[8.12] Upgrade yarn to 1.22.21 in WORKSPACE.bazel (#175632) (#175643)
e4d53bd 
# Backport

This will backport the following commits from `main` to `8.12`:
- [Upgrade yarn to 1.22.21 in WORKSPACE.bazel
(#175632)](#175632)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-01-25T20:39:36Z","message":"Upgrade
yarn to 1.22.21 in WORKSPACE.bazel (#175632)\n\nIn addition to
https://github.com/elastic/kibana/pull/175495","sha":"81ae390daad7e3e19fb3b78bbb153e91869a27dd","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","v8.13.0"],"title":"Upgrade
yarn to 1.22.21 in
WORKSPACE.bazel","number":175632,"url":"https://github.com/elastic/kibana/pull/175632","mergeCommit":{"message":"Upgrade
yarn to 1.22.21 in WORKSPACE.bazel (#175632)\n\nIn addition to
https://github.com/elastic/kibana/pull/175495","sha":"81ae390daad7e3e19fb3b78bbb153e91869a27dd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175632","number":175632,"mergeCommit":{"message":"Upgrade
yarn to 1.22.21 in WORKSPACE.bazel (#175632)\n\nIn addition to
https://github.com/elastic/kibana/pull/175495","sha":"81ae390daad7e3e19fb3b78bbb153e91869a27dd"}}]}]
BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
@jbudz
Copy link
Member

jbudz commented Jan 26, 2024

buildkite test this

@jbudz
Copy link
Member

jbudz commented Jan 26, 2024

buildkite test this

@jbudz
Copy link
Member

jbudz commented Jan 26, 2024

@elasticmachine run elasticsearch-ci/docs

@jbudz
Copy link
Member

jbudz commented Jan 26, 2024

buildkite test this

@jbudz
Copy link
Member

jbudz commented Jan 26, 2024

@elasticmachine run elasticsearch-ci/docs

@jbudz jbudz enabled auto-merge (squash) January 26, 2024 17:22
@jbudz jbudz merged commit 3ad54f6 into elastic:main Jan 26, 2024
40 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- Update dependency sass-embedded to ^1.70.0 (main) (#173230)
- chore(NA): bump node into v20 (#173461)
❌ 8.12 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 175495

Questions ?

Please refer to the Backport tool documentation

@jbudz
Copy link
Member

jbudz commented Jan 26, 2024

Thank you @jacoblee93

jbudz added a commit to jbudz/kibana that referenced this pull request Jan 26, 2024
@jacoblee93 @jbudz
Lock package manager version (elastic#175495)
cb310fa 
I believe the intention was to restrict the `yarn` version to `1.22.19`,
but the current `package.json` setup does not enforce it. This config
change should do it.

None.

None.

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Jon <jon@budzenski.me>
Co-authored-by: Jon <jon@elastic.co>
jbudz added a commit to jbudz/kibana that referenced this pull request Jan 26, 2024
@jacoblee93 @jbudz
Lock package manager version (elastic#175495)
5a1ec58 
I believe the intention was to restrict the `yarn` version to `1.22.19`,
but the current `package.json` setup does not enforce it. This config
change should do it.

None.

None.

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Jon <jon@budzenski.me>
Co-authored-by: Jon <jon@elastic.co>
This was referenced Jan 26, 2024
Merged
Merged
lcawl pushed a commit to lcawl/kibana that referenced this pull request Jan 26, 2024
@jbudz @lcawl
Upgrade yarn to 1.22.21 in WORKSPACE.bazel (elastic#175632)
4ca2633 
In addition to elastic#175495
lcawl pushed a commit to lcawl/kibana that referenced this pull request Jan 26, 2024
@jacoblee93 @jbudz @lcawl
Lock package manager version (elastic#175495)
c1fe152 
## Summary

I believe the intention was to restrict the `yarn` version to `1.22.19`,
but the current `package.json` setup does not enforce it. This config
change should do it.


### Checklist

None.

### Risk Matrix

None.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Jon <jon@budzenski.me>
Co-authored-by: Jon <jon@elastic.co>
jbudz added a commit that referenced this pull request Jan 29, 2024
@jbudz @jacoblee93
[7.17] Lock package manager version (#175495) (#175723)
081efe1 
#175495

Co-authored-by: Jacob Lee <jacoblee93@gmail.com>
@kibanamachine kibanamachine mentioned this pull request Jan 29, 2024
Merged
jbudz added a commit that referenced this pull request Jan 29, 2024
@jbudz @jacoblee93
[8.12] Lock package manager version (#175495) (#175724)
5c66b95 
#175495

---------

Co-authored-by: Jacob Lee <jacoblee93@gmail.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@jbudz @CoenWarmer
Upgrade yarn to 1.22.21 in WORKSPACE.bazel (elastic#175632)
e71c681 
In addition to elastic#175495
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@jacoblee93 @jbudz @CoenWarmer
Lock package manager version (elastic#175495)
2812616 
## Summary

I believe the intention was to restrict the `yarn` version to `1.22.19`,
but the current `package.json` setup does not enforce it. This config
change should do it.


### Checklist

None.

### Risk Matrix

None.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Jon <jon@budzenski.me>
Co-authored-by: Jon <jon@elastic.co>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@jbudz @CoenWarmer
Upgrade yarn to 1.22.21 in WORKSPACE.bazel (elastic#175632)
56b43d1 
In addition to elastic#175495
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@jacoblee93 @jbudz @CoenWarmer
Lock package manager version (elastic#175495)
74a4dcb 
## Summary

I believe the intention was to restrict the `yarn` version to `1.22.19`,
but the current `package.json` setup does not enforce it. This config
change should do it.


### Checklist

None.

### Risk Matrix

None.

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Jon <jon@budzenski.me>
Co-authored-by: Jon <jon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:all-open Backport to all branches that could still receive a release 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jacoblee93 @elasticmachine @jbudz @kibana-ci @kibanamachine @stephmilovic