Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] [kbn/journeys] fix hanging on telemetry call & improve logging (#175194) #175247

Merged
merged 1 commit into from
Jan 22, 2024

Commits on Jan 22, 2024

  1. [kbn/journeys] fix hanging on telemetry call & improve logging (elast…

    …ic#175194)
    
    ## Summary
    
    This PR fixes the issue causing (mostly) [login
    journey](https://buildkite.com/elastic/kibana-single-user-performance/builds/12398#018d1149-cc2e-4591-a61c-176768081e2c)
    stuck for 14 min waiting for Telemetry call response.
    
    <img width="964" alt="Screenshot 2024-01-22 at 11 12 24"
    src="https://github.com/elastic/kibana/assets/10977896/8cadc2ec-ee84-42f6-8a0c-ad949367429c">
    
    I believe the issue was in how we handle the Observables for request
    events. I added extra comment in the particular code change.
    
    I no longer can reproduce it, all the events are reported correctly:
    <img width="964" alt="image"
    src="https://github.com/elastic/kibana/assets/10977896/fa2c4b27-dcf2-480b-a07f-aeb23045149a">
    
    Logs cleaning is to log in console only performance metrics event but
    not all EBT elements. Also not to report some browser errors that not
    Kibana specific.
    
    Testing:
    
    run the following script 3-4 times
    ```
    PERFORMANCE_ENABLE_TELEMETRY=1 node scripts/run_performance.js --journey-path x-pack/performance/journeys/login.ts
    ```
    
    - script is completed without delays (e.g. doesn't hang on after hook in
    TEST phase)
    - telemetry requests are logged with correct counter and all finished,
    e.g. `Waiting for telemetry request elastic#2 to complete` is followed by
    `Telemetry request elastic#2 complete`
    - only events started with `Report event "performance_metric"` are in
    console output
    
    (cherry picked from commit 8be528e)
    dmlemeshko committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5451e4a View commit details
    Browse the repository at this point in the history