[Security Solution] unskip endpoint alerts cypress tests #174493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeypoon
force-pushed
the
fix/flaky-cypress-endpoint-alerts
branch
from
fec0550 to
d461535
Compare
joeypoon
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
gergoabraham
approved these changes
Jan 10, 2024
pzl
approved these changes
Jan 10, 2024
parkiino
approved these changes
Jan 10, 2024
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 10, 2024
) ## Summary Unskip endpoint alerts cypress test. Various enhancements to our tests were previously made, this is just retroactively unskipping after verifying with flaky test runner. Flaky test runs: - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4798 (50x ✅ ) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit f141534)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2024
) (#174641) # Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] unskip endpoint alerts cypress tests (#174493)](#174493) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joey F. Poon","email":"joey.poon@elastic.co"},"sourceCommit":{"committedDate":"2024-01-10T17:21:10Z","message":"[Security Solution] unskip endpoint alerts cypress tests (#174493)\n\n## Summary\r\n\r\nUnskip endpoint alerts cypress test. Various enhancements to our tests\r\nwere previously made, this is just retroactively unskipping after\r\nverifying with flaky test runner.\r\n\r\nFlaky test runs:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4798\r\n(50x ✅ )\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f1415345bac26e594ab76fa223f0b439e1920be8","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.12.0","v8.13.0"],"title":"[Security Solution] unskip endpoint alerts cypress tests","number":174493,"url":"https://github.com/elastic/kibana/pull/174493","mergeCommit":{"message":"[Security Solution] unskip endpoint alerts cypress tests (#174493)\n\n## Summary\r\n\r\nUnskip endpoint alerts cypress test. Various enhancements to our tests\r\nwere previously made, this is just retroactively unskipping after\r\nverifying with flaky test runner.\r\n\r\nFlaky test runs:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4798\r\n(50x ✅ )\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f1415345bac26e594ab76fa223f0b439e1920be8"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174493","number":174493,"mergeCommit":{"message":"[Security Solution] unskip endpoint alerts cypress tests (#174493)\n\n## Summary\r\n\r\nUnskip endpoint alerts cypress test. Various enhancements to our tests\r\nwere previously made, this is just retroactively unskipping after\r\nverifying with flaky test runner.\r\n\r\nFlaky test runs:\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4798\r\n(50x ✅ )\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"f1415345bac26e594ab76fa223f0b439e1920be8"}}]}] BACKPORT--> Co-authored-by: Joey F. Poon <joey.poon@elastic.co>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Jan 11, 2024
) ## Summary Unskip endpoint alerts cypress test. Various enhancements to our tests were previously made, this is just retroactively unskipping after verifying with flaky test runner. Flaky test runs: - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4798 (50x ✅ ) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unskip endpoint alerts cypress test. Various enhancements to our tests were previously made, this is just retroactively unskipping after verifying with flaky test runner.
Flaky test runs:
For maintainers