Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade slack/webhook #173933

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Upgrade slack/webhook #173933

merged 2 commits into from
Jan 2, 2024

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 22, 2023

@jbudz jbudz added the release_note:skip Skip the PR/issue when compiling release notes label Dec 22, 2023
@jbudz
Copy link
Member Author

jbudz commented Dec 22, 2023

buildkite test this

@jbudz jbudz marked this pull request as ready for review December 22, 2023 19:11
@jbudz jbudz requested a review from a team December 22, 2023 19:11
@jbudz jbudz added the backport:all-open Backport to all branches that could still receive a release label Dec 22, 2023
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested posting to a slack webhook with this branch, continues to work fine. No obvious API changes that I can tell.

@jbudz jbudz enabled auto-merge (squash) January 2, 2024 14:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 04b832b into elastic:main Jan 2, 2024
35 of 36 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2024
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 173933

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 2, 2024
# Backport

This will backport the following commits from `main` to `8.12`:
- [Upgrade slack/webhook
(#173933)](#173933)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-01-02T15:49:12Z","message":"Upgrade
slack/webhook
(#173933)\n\nhttps://github.com/slackapi/node-slack-sdk/commits/main/packages/webhook","sha":"04b832bda9ea31b5c41dd83e09be51dde4b25fbf","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.13.0"],"title":"Upgrade
slack/webhook","number":173933,"url":"https://github.com/elastic/kibana/pull/173933","mergeCommit":{"message":"Upgrade
slack/webhook
(#173933)\n\nhttps://github.com/slackapi/node-slack-sdk/commits/main/packages/webhook","sha":"04b832bda9ea31b5c41dd83e09be51dde4b25fbf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173933","number":173933,"mergeCommit":{"message":"Upgrade
slack/webhook
(#173933)\n\nhttps://github.com/slackapi/node-slack-sdk/commits/main/packages/webhook","sha":"04b832bda9ea31b5c41dd83e09be51dde4b25fbf"}}]}]
BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
jbudz added a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants