[Security solution] Assistant telemetry conversation id fix #173794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
| assistantTelemetry?.reportAssistantInvoked({ | ||
| invokedBy: 'shortcut', | ||
| conversationId: localStorageLastConversationId ?? WELCOME_CONVERSATION_TITLE, | ||
| conversationId: getConversationId(), |
There was a problem hiding this comment.
Thanks for ensuring all code paths return a consistent id with the new getConversationId() function!
The expected conversation id is included when the assistant is launched from the:
💹 Alerts flyout / page
💹 Data quality results / page
💹 Cases page
💹 Timeline
...and other contexts.
💹 The expected conversation ID is included for both default (e.g. Alert summary) and Custom conversations
andrew-goldstein
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Thanks @stephmilovic for this telemetry update!
✅ Desk tested locally
LGTM 🚀
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 21, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 21, 2023
…173794) (#173843) # Backport This will backport the following commits from `main` to `8.12`: - [[Security solution] Assistant telemetry conversation id fix (#173794)](#173794) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"stephanie.milovic@elastic.co"},"sourceCommit":{"committedDate":"2023-12-21T14:40:49Z","message":"[Security solution] Assistant telemetry conversation id fix (#173794)","sha":"574ff80c444fcaa2717f8578ba4af09c5a433c06","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team: SecuritySolution","Team:Threat Hunting:Explore","Feature:GenAI","v8.12.0","v8.13.0"],"number":173794,"url":"https://github.com/elastic/kibana/pull/173794","mergeCommit":{"message":"[Security solution] Assistant telemetry conversation id fix (#173794)","sha":"574ff80c444fcaa2717f8578ba4af09c5a433c06"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173794","number":173794,"mergeCommit":{"message":"[Security solution] Assistant telemetry conversation id fix (#173794)","sha":"574ff80c444fcaa2717f8578ba4af09c5a433c06"}}]}] BACKPORT--> Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We track telemetry when the AI Assistant button is clicked into, including the
conversationId. However, when we introduced the new global header menu, theconversationIdgot dropped. This PR fixes that by introducing a new method,getConversationIdthat will default to thelocalStorageLastConversationIdand then the Welcome id if no local storage id is present. This method is shared anywhere theconversationIdis referenced.To test
telemetry.optIn: trueis defined in your dev ymlReport event "Assistant Invoked". Expand the event and find the id inproperties.conversationId. Ensure that it is the same conversation that was openedReport event "Assistant Invoked". Expand the event and ensure the expectedproperties.conversationIdwas sent