-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Fall back to request.url for kibana function #173717
[Obs AI Assistant] Fall back to request.url for kibana function #173717
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@elasticmachine merge upstream |
…ibana into obs-ai-assistant-kibana-ssl
httpsAgent: new https.Agent({ | ||
rejectUnauthorized: false, | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we think this is safe because the request is coming from within Kibana to Kibana itself, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I'm mostly just testing still. Should have mentioned that.
…ibana into obs-ai-assistant-kibana-ssl
resources.logger.info(JSON.stringify(request.url)); | ||
resources.logger.info(JSON.stringify(request.headers, null)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to inspect the cloud deployment. I'll remove the statements entirely (because this leaks security details 😛)
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…3717) (#173916) # Backport This will backport the following commits from `main` to `8.12`: - [[Obs AI Assistant] Fall back to request.url for kibana fn (#173717)](#173717) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dario Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2023-12-22T11:54:44Z","message":"[Obs AI Assistant] Fall back to request.url for kibana fn (#173717)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Justin Kambic <jk@elastic.co>","sha":"31b7380c107550774bbb93d643a9446434f8b0a9","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:cloud-deploy","ci:cloud-persist-deployment","v8.12.0","v8.12.1","v8.13.0"],"number":173717,"url":"https://github.com/elastic/kibana/pull/173717","mergeCommit":{"message":"[Obs AI Assistant] Fall back to request.url for kibana fn (#173717)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Justin Kambic <jk@elastic.co>","sha":"31b7380c107550774bbb93d643a9446434f8b0a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173717","number":173717,"mergeCommit":{"message":"[Obs AI Assistant] Fall back to request.url for kibana fn (#173717)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Justin Kambic <jk@elastic.co>","sha":"31b7380c107550774bbb93d643a9446434f8b0a9"}}]}] BACKPORT--> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
null