upgrade EUI to 0.0.26 #17110
Merged
upgrade EUI to 0.0.26 #17110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
approved these changes
Mar 12, 2018
|
Just a reminder cause this is coming up again, please run reporting tests with this PR to make sure they still pass. screenshots might need to be updated. Though you'll have to wait till they are actually passing again. 😢 |
|
@jen-huang is already fixing this in #17074 |
💔 Build Failed |
|
Closing in favor of #17074 |
|
@chrisronline @cjcenizal I am re-opening this PR. |
💔 Build Failed |
|
jenkins, test this |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 13, 2018
* upgrade EUI to 0.0.25 * remove last reference to TooltipTrigger * upgraded to EUI 0.0.26 * fix warning, EuiKeyboardAccessible child must have onClick defined
This was referenced Mar 13, 2018
nreese
added a commit
that referenced
this pull request
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old EUI tooltips where kind of broken. Notice how the tooltip does not line up with the clock icon
