[SLO] Allow users to define burn rate windows using budget consumed

[simianhacker]

Summary

This PR fixes #170854 and #170859 by allowing the user to define the burn rate windows using either a burn rate threshold or the % of budget consumed by the time the alert triggers. This PR also adds the budget consumed to the help text below the burn rate window definition. I also changed the behavior to hide the window definitions until the Selected SLO is chosen since we need the SLO for the calculations.

Screen.Recording.2023-11-09.at.5.14.59.PM.mov

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[kdelemme]

I think there is one test on the min burn rate threshold to change, but otherwise, it looks good!

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[mgiota]

@simianhacker Looks good! Is there a reason you changed from first decimal (14.4) to second decimal (14.40)?

I was wondering if it is better to have the toggle on top of the form vs at the bottom. @maciejforcone What do you think? I guess Maciej will cover the positioning of the configuration(toggle) as part of this issue, so I don't want to block this PR.

[mgiota]

I played a bit with the form, deleting and readding a window. I just want to confirm if the default values for the new window are good or if we need to revisit.

Screen.Recording.2023-11-10.at.21.03.19.mov

[simianhacker]

@mgiota I switched to 2 decimal places because when you configure via budget consumed, we needed the extra decimal for the 7 day 1 hour burn rate for 2% budget consumed which is 3.36x

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: c82cf90

Failed CI Steps

• Defend Workflows Cypress Tests on Serverless #5

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
observability	490	491	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
observability	1.1MB	1.1MB	+1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
observability	104.1KB	104.1KB	+5.0B

History

• 💔 Build #175154 failed 7f2d4a4
• 💚 Build #175046 succeeded 75748ff
• 💔 Build #174820 failed 137cfbd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream