[RAM] Makes anomaly detection rule visible in Observability #170451

XavierM · 2023-11-02T16:28:52Z

Summary

From the rule management page in observability, user will be able to create an anomaly detection rule.

…oly-in-011y

elasticmachine · 2023-12-04T22:37:34Z

Pinging @elastic/response-ops (Team:ResponseOps)

JiaweiWu

triggers actions UI changes LGTM

elasticmachine · 2023-12-04T23:37:49Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

darnautov · 2023-12-05T10:03:28Z

FYI the PR to set anomaly description as an alert message

packages/kbn-rule-data-utils/src/rule_types/stack_rules.ts

darnautov

I reckon we should rename the const for consistency. The rest LGTM!

marshallmain

D&R changes LGTM

maryam-saeidi

The name of the new rule is Anomaly detection alert which does not match the rest of the rules, can we remove the alert keyword from this rule name? (Or was this name suggested by the PMs?)
In case of not having an ML job, there is no option to create one from the flyout:

Is there a feature to add this option? (I assume not related to this PR just noticed it here)
Also, in case of having basic license, SLO rule is shown in disabled mode but the ML Anomaly one is not shown at all, is this expected?

The license error and the link to fix it is amaing 😍

maryam-saeidi · 2023-12-13T18:23:17Z

x-pack/plugins/observability/public/hooks/use_get_filtered_rule_types.ts

-    return [ES_QUERY_ID, ...observabilityRuleTypeRegistry.list()];
+    return [
+      ES_QUERY_ID,
+      ML_ANOMALY_DETECTION_RULE_TYPE_ID,


@vinaychandrasekhar @katrin-freihofner Currently, the Anomaly rule is the second item in the rules list, since it is Beta, should we move it to the end of the list? (Also, in case of no ML job, the flyout does not have an option to send the user to create one.)

FYI It's not in Beta anymore :)

I discussed this with Vinay, and the current order is good.

cauemarcondes

LGTM

darnautov · 2023-12-18T14:51:08Z

thanks for the feedback @maryam-saeidi!

The name of the new rule is Anomaly detection alert which does not match the rest of the rules, can we remove the alert keyword from this rule name? (Or was this name suggested by the PMs?)

I recall we called it like this to avoid confusion with the Anomaly detection as a feature itself. I don't have any objections to renaming it for consistency with the other rule types. @peteharverson wdyt?

In case of not having an ML job, there is no option to create one from the flyout:
Is there a feature to add this option? (I assume not related to this PR just noticed it here)

Good point, created an issue for that #173654 , aiming to deliver in 8.13.

Also, in case of having basic license, SLO rule is shown in disabled mode but the ML Anomaly one is not shown at all, is this expected?

If you browse the Anomaly detection rule in the Rules management UI, it is disabled in a similar fashion as the SLO rule you mentioned. @XavierM can you please check if any additional config is needed here?

peteharverson · 2023-12-18T16:46:05Z

The name of the new rule is Anomaly detection alert which does not match the rest of the rules, can we remove the alert keyword from this rule name? (Or was this name suggested by the PMs?)

Agree that for consistency we can remove alert from the rule name here. The description makes it clear that the rule is alerting on jobs.

XavierM · 2023-12-18T20:28:48Z

@darnautov and @peteharverson
FYI -> I also found this bug during testing #173573

XavierM · 2023-12-18T22:52:26Z

If you browse the Anomaly detection rule in the Rules management UI, it is disabled in a similar fashion as the SLO rule you mentioned. @XavierM can you please check if any additional config is needed here?

@darnautov I just checked it and I do not see the same thing that you are seeing?

With the license ->

With NO license ->

I think the problem is here -> https://github.com/elastic/kibana/blob/main/x-pack/plugins/ml/public/plugin.ts#L207 because if you do not have a full license, you are not registering the anomaly detection rule. So that's why it is not showing up!

darnautov · 2023-12-19T08:41:16Z

The name of the new rule is Anomaly detection alert which does not match the rest of the rules, can we remove the alert keyword from this rule name? (Or was this name suggested by the PMs?)

Agree that for consistency we can remove alert from the rule name here. The description makes it clear that the rule is alerting on jobs.

FYI It's been renamed in #173545, cc @maryam-saeidi @XavierM

darnautov · 2023-12-19T15:01:36Z

If you browse the Anomaly detection rule in the Rules management UI, it is disabled in a similar fashion as the SLO rule you mentioned. @XavierM can you please check if any additional config is needed here?

@darnautov I just checked it and I do not see the same thing that you are seeing?

With the license ->

With NO license ->

I think the problem is here -> https://github.com/elastic/kibana/blob/main/x-pack/plugins/ml/public/plugin.ts#L207 because if you do not have a full license, you are not registering the anomaly detection rule. So that's why it is not showing up!

@XavierM tested and realised we added some unnecessary guards for registering ML alerting rules. I created a PR to address it #173644. When it's merged the Anomaly detection rule type should be visible with the basic license as well, but the entry in the list is disabled.

darnautov · 2023-12-19T18:32:35Z

I can set a role visibility during the rule creation but it's not visible on edit. Is it expected behaviour?

darnautov

LGTM

kibana-ci · 2023-12-21T03:18:21Z

💚 Build Succeeded

Buildkite Build
Commit: 06f2a48

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/rule-data-utils`	116	117	+1
`ml`	64	65	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	3.6MB	3.6MB	+4.0B
`observability`	587.1KB	587.2KB	+39.0B
`triggersActionsUi`	1.4MB	1.4MB	+9.0B
total			+52.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	78.0KB	78.1KB	+62.0B
`triggersActionsUi`	104.2KB	104.2KB	+75.0B
total			+137.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/rule-data-utils`	119	120	+1
`ml`	150	151	+1
total			+2

History

💚 Build #184443 succeeded ec9888b
💛 Build #184237 was flaky bf7d682
💚 Build #183448 succeeded b45e067
💛 Build #182986 was flaky 330742f
💛 Build #182822 was flaky 9bf6cd3
💔 Build #182518 failed dffb17d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

maryam-saeidi

LGTM!

XavierM added 3 commits November 1, 2023 12:11

possible to only have two errors

4cdfcc9

Merge branch 'main' of github.com:elastic/kibana

9850588

add anomaly to o11y

829f65a

XavierM added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 labels Nov 2, 2023

Merge branch 'main' into anamoly-in-011y

f8280d8

XavierM mentioned this pull request Nov 14, 2023

[RAM] Machine learning alerts working with cases #171150

Closed

XavierM added 2 commits December 4, 2023 16:41

Merge branch 'main' of github.com:elastic/kibana into anamoly-in-011y

6116d4d

Merge branch 'anamoly-in-011y' of github.com:XavierM/kibana into anam…

5760512

…oly-in-011y

XavierM marked this pull request as ready for review December 4, 2023 22:37

XavierM requested review from a team as code owners December 4, 2023 22:37

JiaweiWu approved these changes Dec 4, 2023

View reviewed changes

botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 4, 2023

darnautov reviewed Dec 5, 2023

View reviewed changes

packages/kbn-rule-data-utils/src/rule_types/stack_rules.ts Outdated Show resolved Hide resolved

darnautov requested changes Dec 5, 2023

View reviewed changes

marshallmain approved these changes Dec 6, 2023

View reviewed changes

XavierM added 2 commits December 6, 2023 12:34

dima review

e2a8dae

Merge branch 'main' of github.com:elastic/kibana into anamoly-in-011y

0dadb74

XavierM requested a review from darnautov December 6, 2023 17:35

XavierM added v8.13.0 and removed v8.12.0 labels Dec 6, 2023

XavierM added the release_note:skip Skip the PR/issue when compiling release notes label Dec 6, 2023

XavierM added 7 commits December 7, 2023 10:11

default scope to stackAlerts

9cf123c

Merge branch 'main' of github.com:elastic/kibana into anamoly-in-011y

dffb17d

Merge branch 'main' of github.com:elastic/kibana into anamoly-in-011y

b154c44

allow alerts as a consumer if nothing else is valid

f7a634c

Merge branch 'main' of github.com:elastic/kibana into anamoly-in-011y

9bf6cd3

Merge branch 'main' into anamoly-in-011y

330742f

Merge branch 'main' into anamoly-in-011y

b45e067

maryam-saeidi reviewed Dec 13, 2023

View reviewed changes

cauemarcondes approved these changes Dec 14, 2023

View reviewed changes

XavierM changed the title ~~[RAM] add ML anomaly in 011y~~ [RAM] Makes anomaly detection rule visible in Observability Dec 18, 2023

Merge branch 'main' of github.com:elastic/kibana into anamoly-in-011y

d10cc49

Merge branch 'main' of github.com:elastic/kibana into anamoly-in-011y

bf7d682

Merge branch 'main' into anamoly-in-011y

ec9888b

darnautov approved these changes Dec 20, 2023

View reviewed changes

Merge branch 'main' into anamoly-in-011y

06f2a48

maryam-saeidi approved these changes Dec 21, 2023

View reviewed changes

XavierM merged commit 80edac1 into elastic:main Dec 21, 2023
35 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Dec 21, 2023

maryam-saeidi mentioned this pull request Jan 25, 2024

Observability - possibility of visualizing the Machine Learning Anomaly alerts together with all the other alerts in Observability alerts page #175169

Closed

maryam-saeidi mentioned this pull request Mar 22, 2024

Show Stack management rules as part of the Observability rules and alerts tables #157140

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RAM] Makes anomaly detection rule visible in Observability #170451

[RAM] Makes anomaly detection rule visible in Observability #170451

XavierM commented Nov 2, 2023 •

edited

Loading

elasticmachine commented Dec 4, 2023

JiaweiWu left a comment

elasticmachine commented Dec 4, 2023

darnautov commented Dec 5, 2023

darnautov left a comment

marshallmain left a comment

maryam-saeidi left a comment •

edited

Loading

maryam-saeidi Dec 13, 2023

darnautov Dec 19, 2023

maryam-saeidi Dec 21, 2023

cauemarcondes left a comment

darnautov commented Dec 18, 2023 •

edited

Loading

peteharverson commented Dec 18, 2023

XavierM commented Dec 18, 2023

XavierM commented Dec 18, 2023

darnautov commented Dec 19, 2023

darnautov commented Dec 19, 2023

darnautov commented Dec 19, 2023

darnautov left a comment

kibana-ci commented Dec 21, 2023

API count

maryam-saeidi left a comment

[RAM] Makes anomaly detection rule visible in Observability #170451

[RAM] Makes anomaly detection rule visible in Observability #170451

Conversation

XavierM commented Nov 2, 2023 • edited Loading

Summary

elasticmachine commented Dec 4, 2023

JiaweiWu left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 4, 2023

darnautov commented Dec 5, 2023

darnautov left a comment

Choose a reason for hiding this comment

marshallmain left a comment

Choose a reason for hiding this comment

maryam-saeidi left a comment • edited Loading

Choose a reason for hiding this comment

maryam-saeidi Dec 13, 2023

Choose a reason for hiding this comment

darnautov Dec 19, 2023

Choose a reason for hiding this comment

maryam-saeidi Dec 21, 2023

Choose a reason for hiding this comment

cauemarcondes left a comment

Choose a reason for hiding this comment

darnautov commented Dec 18, 2023 • edited Loading

peteharverson commented Dec 18, 2023

XavierM commented Dec 18, 2023

XavierM commented Dec 18, 2023

darnautov commented Dec 19, 2023

darnautov commented Dec 19, 2023

darnautov commented Dec 19, 2023

darnautov left a comment

Choose a reason for hiding this comment

kibana-ci commented Dec 21, 2023

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

maryam-saeidi left a comment

Choose a reason for hiding this comment

XavierM commented Nov 2, 2023 •

edited

Loading

maryam-saeidi left a comment •

edited

Loading

darnautov commented Dec 18, 2023 •

edited

Loading