fix(slo): remove react query cache for slo list page #170318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
commented
Nov 1, 2023
| queryClient.invalidateQueries({ queryKey: sloKeys.rules(), exact: false }); | ||
| return response; | ||
| }, | ||
| cacheTime: 0, |
There was a problem hiding this comment.
💬 Only change is here.
Added cacheTime, removed staleTime and keepPreviousData
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @kdelemme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #170317
🥡 Summary
When changing pages, we observed a weird behaviour where the result of the API was not fully taken into account, and was kind of merged with the previous results. After some investigation, it seems the cacheTime (default to 5min) was problematic in our case.
This PR forces
cacheTimeto 0, so when changing page, we only use the result from the API.