[Security Solution] add handling for endpoint package spec v2 #169901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeypoon
added
release_note:skip
joeypoon
changed the title
joeypoon
force-pushed
the
feature/endpoint-package-v2
branch
from
6fdbf5e
to
3e29882
Compare
endpoint package managed transform names are changing with the endpoint package migration to package spec v2. this commit updates places where we rely on these transform names. backwards compatible.
joeypoon
force-pushed
the
feature/endpoint-package-v2
branch
from
3e29882
to
1395607
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
pzl
approved these changes
Oct 26, 2023
kevinlog
approved these changes
Oct 26, 2023
|
This was reverted with 638d070 due to an import of Logs can be found at https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/3352#018b6e02-b9a6-4154-b470-0fd1248f5942/852-857 |
1 task
joeypoon
added a commit
that referenced
this pull request
Oct 27, 2023
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Oct 30, 2023
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Oct 30, 2023
…elastic#169901)" This reverts commit 82880fe.
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Oct 30, 2023
…nt package spec v2 (elastic#170069)
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Oct 30, 2023
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Oct 30, 2023
…elastic#169901)" This reverts commit 82880fe.
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Oct 30, 2023
…nt package spec v2 (elastic#170069)
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Oct 31, 2023
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Oct 31, 2023
…elastic#169901)" This reverts commit 82880fe.
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Oct 31, 2023
…nt package spec v2 (elastic#170069)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Endpoint package is being upgraded to package spec v2. This upgrade causes the package managed transform names to change (now prefixed with an additional
logs-). This PR updates all the places we're using the transform names to conditionally either use the v1 transform names or the v2 transform names depending on the package version to maintain backwards compatibility.Also unskips
x-pack/test/security_solution_endpoint_api_int/apis/metadata.tstests. Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3763 (x100 ✅ ).Checklist
For maintainers