Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] fix breadcrumbs for alerts and slo #169778

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Oct 25, 2023

Summary

Close #161447

This fixes deeper context breadcrumbs in serverless observability project for alerts and slos apps.
This builds on top of #169513 where we added merging of navigational project breadcrumbs with deeper context breadcrumbs set by chrome.setBreadcrumbs. The merging is based on deepLinkId, so we're adding it to base breadcrumbs. The deepLinkId is type checked.

Screenshot 2023-10-25 at 12 28 07
Screenshot 2023-10-25 at 12 28 16

@Dosant Dosant changed the title fix breadcrumbs for alerts and slo [Serverless] fix breadcrumbs for alerts and slo Oct 25, 2023
@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) labels Oct 25, 2023
@Dosant Dosant self-assigned this Oct 25, 2023
@Dosant Dosant force-pushed the d/2023-10-25-fix-alerts-breadcrumbs branch from 4eadc03 to 8fa3ed2 Compare October 25, 2023 16:12
@Dosant
Copy link
Contributor Author

Dosant commented Oct 26, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / logstash pipeline list route "after all" hook for "shows example pipelines"
  • [job] [logs] FTR Configs #34 / logstash pipeline list route "before each" hook for "links to the pipeline editor with cloned pipeline details"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +252.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Dosant

@Dosant Dosant marked this pull request as ready for review October 26, 2023 09:42
@Dosant Dosant requested a review from a team as a code owner October 26, 2023 09:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@mgiota mgiota self-requested a review October 26, 2023 12:28
@mgiota
Copy link
Contributor

mgiota commented Oct 26, 2023

Code review looks good to me. I want to test it locally as well, before I approve

Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested both serverless and stateful and breadcrumbs look good! I attach a screenshot from serverless. I just noticed that your PR is missing a release version label.

Screenshot 2023-10-26 at 21 54 32

@Dosant Dosant merged commit cb2a6e5 into elastic:main Oct 27, 2023
28 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 27, 2023
@Dosant
Copy link
Contributor Author

Dosant commented Oct 27, 2023

Code review looks good to me. I want to test it locally as well, before I approve

Thanks! afaik they are added automatically by kibanamachine depending on the backports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[o11y alerting serverless] Incomplete breadcrumbs
5 participants