-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] fix breadcrumbs for alerts and slo #169778
[Serverless] fix breadcrumbs for alerts and slo #169778
Conversation
4eadc03
to
8fa3ed2
Compare
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Dosant |
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Code review looks good to me. I want to test it locally as well, before I approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! afaik they are added automatically by kibanamachine depending on the backports |
Summary
Close #161447
This fixes deeper context breadcrumbs in serverless observability project for alerts and slos apps.
This builds on top of #169513 where we added merging of navigational project breadcrumbs with deeper context breadcrumbs set by
chrome.setBreadcrumbs
. The merging is based on deepLinkId, so we're adding it to base breadcrumbs. The deepLinkId is type checked.