Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES|QL in-product help fixes #169618

Merged
merged 2 commits into from
Oct 24, 2023
Merged

ES|QL in-product help fixes #169618

merged 2 commits into from
Oct 24, 2023

Conversation

abdonpijpelink
Copy link
Contributor

@abdonpijpelink abdonpijpelink commented Oct 24, 2023 •
edited by kibanamachine
Loading

Changes the ES|QL in-product help:

  • opens links to the documentation in a new tab
  • swaps the arguments for the DATE_* functions

Closes #169428

@abdonpijpelink abdonpijpelink added release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Oct 24, 2023
@abdonpijpelink abdonpijpelink requested a review from a team as a code owner October 24, 2023 09:07
@stratoula stratoula added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.12.0 Feature:ES|QL ES|QL related features in Kibana labels Oct 24, 2023
stratoula
stratoula approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, code review only

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #3 / ALL - Live Query should run multiline query should run multiline query
  • [job] [logs] Security Solution Cypress Tests #9 / Changing alert status Opening alerts can bulk open alerts can bulk open alerts

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +105.0B
stackAlerts 202.9KB 203.0KB +105.0B
textBasedLanguages 148.8KB 148.9KB +105.0B
total +315.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@abdonpijpelink abdonpijpelink merged commit 141616e into elastic:main Oct 24, 2023
@abdonpijpelink abdonpijpelink deleted the esql-help-fixes branch October 24, 2023 10:47
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2023
@abdonpijpelink
ES|QL in-product help fixes (elastic#169618)
b7031ab 
Changes the ES|QL in-product help:

- opens links to the documentation in a new tab
- swaps the arguments for the DATE_* functions

Closes elastic#169428

(cherry picked from commit 141616e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2023
@kibanamachine @abdonpijpelink
[8.11] ES|QL in-product help fixes (#169618) (#169632)
9e4577f 
# Backport

This will backport the following commits from `main` to `8.11`:
- [ES|QL in-product help fixes
(#169618)](#169618)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Abdon
Pijpelink","email":"abdon.pijpelink@elastic.co"},"sourceCommit":{"committedDate":"2023-10-24T10:47:42Z","message":"ES|QL
in-product help fixes (#169618)\n\nChanges the ES|QL in-product
help:\r\n\r\n- opens links to the documentation in a new tab\r\n- swaps
the arguments for the DATE_* functions\r\n\r\nCloses
https://github.com/elastic/kibana/issues/169428","sha":"141616e2d8a6323fe4bff7e9f05e83730db01879","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.11.0","Feature:ES|QL","v8.12.0"],"number":169618,"url":"https://github.com/elastic/kibana/pull/169618","mergeCommit":{"message":"ES|QL
in-product help fixes (#169618)\n\nChanges the ES|QL in-product
help:\r\n\r\n- opens links to the documentation in a new tab\r\n- swaps
the arguments for the DATE_* functions\r\n\r\nCloses
https://github.com/elastic/kibana/issues/169428","sha":"141616e2d8a6323fe4bff7e9f05e83730db01879"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169618","number":169618,"mergeCommit":{"message":"ES|QL
in-product help fixes (#169618)\n\nChanges the ES|QL in-product
help:\r\n\r\n- opens links to the documentation in a new tab\r\n- swaps
the arguments for the DATE_* functions\r\n\r\nCloses
https://github.com/elastic/kibana/issues/169428","sha":"141616e2d8a6323fe4bff7e9f05e83730db01879"}}]}]
BACKPORT-->

Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ES|QL] Doc links should open a new tab
4 participants
@abdonpijpelink @kibana-ci @kibanamachine @stratoula