Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Improve reading user permissions #169601

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

awahab07
Copy link
Contributor

@awahab07 awahab07 commented Oct 24, 2023

Summary

The PR improves the way to determine what permissions user has.

@awahab07 awahab07 added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Oct 24, 2023
@awahab07 awahab07 requested a review from a team as a code owner October 24, 2023 00:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@awahab07 awahab07 force-pushed the synthetics-dev-264-permissions-issue branch 2 times, most recently from 2a3bf1b to 6c92eeb Compare October 26, 2023 12:53
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@awahab07 awahab07 force-pushed the synthetics-dev-264-permissions-issue branch from 9ee71c8 to 2fa8a5e Compare October 31, 2023 16:00
@awahab07 awahab07 requested review from a team as code owners October 31, 2023 16:00
@awahab07 awahab07 removed request for a team, spong, tomsonpl and paul-tavares October 31, 2023 16:05
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 31, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 865.0KB 865.5KB +447.0B
uptime 478.4KB 478.5KB +106.0B
total +553.0B

History

  • 💔 Build #171499 failed 70e20c5c5b13fd3edc06060f15868943b8516a43
  • 💚 Build #171178 succeeded 6c92eeb55ee6a764d3f71eb0c55029d58d9f8923
  • 💛 Build #170775 was flaky 2a3bf1ba0fc7f59b16b910c7313f5632f966b140
  • 💔 Build #170168 failed 74d0fc4f3f2ffced9c7a917d5114bfe91e003435

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@awahab07 awahab07 merged commit fce380d into elastic:main Oct 31, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 31, 2023
## Summary

The PR improves the way to determine what permissions user has.

(cherry picked from commit fce380d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 31, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Synthetics] Improve reading user permissions
(#169601)](#169601)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Abdul Wahab
Zahid","email":"awahab07@yahoo.com"},"sourceCommit":{"committedDate":"2023-10-31T18:45:32Z","message":"[Synthetics]
Improve reading user permissions (#169601)\n\n## Summary\r\n\r\nThe PR
improves the way to determine what permissions user
has.","sha":"fce380dadbf156d8f24f919c1bd680548653ce27","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.11.0","v8.12.0"],"number":169601,"url":"https://github.com/elastic/kibana/pull/169601","mergeCommit":{"message":"[Synthetics]
Improve reading user permissions (#169601)\n\n## Summary\r\n\r\nThe PR
improves the way to determine what permissions user
has.","sha":"fce380dadbf156d8f24f919c1bd680548653ce27"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169601","number":169601,"mergeCommit":{"message":"[Synthetics]
Improve reading user permissions (#169601)\n\n## Summary\r\n\r\nThe PR
improves the way to determine what permissions user
has.","sha":"fce380dadbf156d8f24f919c1bd680548653ce27"}}]}] BACKPORT-->

Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
delanni pushed a commit to delanni/kibana that referenced this pull request Nov 6, 2023
## Summary

The PR improves the way to determine what permissions user has.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants