Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCR] Fix a11y issue in remote cluster form #169511

Merged
merged 5 commits into from
Oct 24, 2023
Merged

[CCR] Fix a11y issue in remote cluster form #169511

merged 5 commits into from
Oct 24, 2023

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Oct 23, 2023 •
edited
Loading

Fixes #153599

Summary

This PR fixes the a11y issue in the Remote cluster select field in the Remote cluster form by adding an aria-label attribute.

Before:
Screenshot 2023-10-23 at 12 38 49

Now:
Screenshot 2023-10-23 at 12 39 21

Note: The relevant a11y test is still skipped because the test setup fails when trying to create a remote cluster. Opened #169512 to track this.

@ElenaStoeva ElenaStoeva added Feature:CCR and Remote Clusters Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Oct 23, 2023
@ElenaStoeva ElenaStoeva self-assigned this Oct 23, 2023
@ElenaStoeva ElenaStoeva marked this pull request as ready for review October 23, 2023 12:02
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner October 23, 2023 12:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@ElenaStoeva
Copy link
Contributor Author

@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @ElenaStoeva! Left a suggestion about the copy. Code changes LGTM.

x-pack/plugins/cross_cluster_replication/public/app/components/remote_clusters_form_field.js Outdated
aria-label={i18n.translate(
'xpack.crossClusterReplication.remoteClustersFormField.remoteClusterSelectAriaLabel',
{
defaultMessage: 'Remote cluster',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making this a little more descriptive? Something like "Remote cluster selection" or "Remote cluster dropdown"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I think "Remote cluster selection" is a suitable description. Added with 5f0f829

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) October 24, 2023 09:37
@ElenaStoeva
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #4 / Live query GET getLiveQueryDetailsRoute "before each" hook for "validates we get successful response" "before each" hook for "validates we get successful response"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
crossClusterReplication 146.2KB 146.4KB +160.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva merged commit b154371 into elastic:main Oct 24, 2023
29 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 24, 2023
@ElenaStoeva ElenaStoeva deleted the ccr/a11y branch October 24, 2023 14:13
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Oct 25, 2023
@ElenaStoeva @kibanamachine @cqliu1
[CCR] Fix a11y issue in remote cluster form (elastic#169511)
225a0fc 
Fixes elastic#153599

## Summary

This PR fixes the a11y issue in the Remote cluster select field in the
Remote cluster form by adding an `aria-label` attribute.

**Before:**
<img width="1754" alt="Screenshot 2023-10-23 at 12 38 49"
src="https://github.com/elastic/kibana/assets/59341489/721bb584-fbcd-4a95-8f71-63e270523071">


**Now:**
<img width="1754" alt="Screenshot 2023-10-23 at 12 39 21"
src="https://github.com/elastic/kibana/assets/59341489/c6576dd5-4456-4b05-a819-413a0e4dac36">


**Note:** The relevant a11y test is still
[skipped](https://github.com/elastic/kibana/blob/6adb8bde2b969671abddb66a019b0253bc511cfd/x-pack/test/accessibility/config.ts#L53)
because the test setup fails when trying to create a remote cluster.
Opened elastic#169512 to track this.


<!---
### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
-->

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees

@ElenaStoeva ElenaStoeva

Labels
backport:skip This commit does not require backporting Feature:CCR and Remote Clusters release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensures select element has an accessible name a11y rule violation on create follow index form
5 participants
@ElenaStoeva @elasticmachine @kibana-ci @alisonelizabeth @kibanamachine