[Serverless] Improve cases breadcrumbs in oblt project #169401

Dosant · 2023-10-19T13:44:12Z

Summary

partially fixes #161447

Fixed "Create Case" and "Manage Cases" breadcrumbs

fix.cases.breadcrumbs.mov

Dosant · 2023-10-19T14:07:20Z

packages/shared-ux/chrome/navigation/src/ui/hooks/use_init_navnode.ts

@@ -59,7 +59,7 @@ function getNodeStatus(
    if (!hasUserAccessToCloudLink()) return 'remove';
  }

-  if (deepLink && deepLink.hidden) return 'remove';
+  if (deepLink && deepLink.hidden) return 'hidden';


@sebelga, the newly added

{ link: 'observability-overview:cases_configure', }, { link: 'observability-overview:cases_create', },

are used for the breadcrumbs, but their deep links are "hidden".

The fix I did is to keep such links in the navigation tree for the breadcrumbs, but filter them out when rendering the side nav to keep them hidden from the navigation.

elasticmachine · 2023-10-19T14:08:19Z

Pinging @elastic/appex-sharedux (Team:SharedUX)

cnasikas

I tested on Serverless (all projects) and in ESS (all solutions) and is working as expected! Probably unrelated to this PR but I noticed that the text is different in the breadcrumbs between Serverless and ESS

Serverless

ESS

cc @semd

Dosant · 2023-10-23T09:44:51Z

@cnasikas, thanks!

In serverless the texts are coming from deep links definition:

kibana/x-pack/plugins/cases/public/common/navigation/deep_links.ts

Lines 34 to 49 in 3730dd0

    
           { 
        
             title: i18n.translate('xpack.cases.navigation.create', { 
        
               defaultMessage: 'Create New Case', 
        
             }), 
        
             ...(extend[CasesDeepLinkId.casesCreate] ?? {}), 
        
             id: CasesDeepLinkId.casesCreate, 
        
             path: getCreateCasePath(basePath), 
        
           }, 
        
           { 
        
             title: i18n.translate('xpack.cases.navigation.configure', { 
        
               defaultMessage: 'Configure Cases', 
        
             }), 
        
             ...(extend[CasesDeepLinkId.casesConfigure] ?? {}), 
        
             id: CasesDeepLinkId.casesConfigure, 
        
             path: getCasesConfigurePath(basePath), 
        
           },

where in ESS it is from whatever is imperatively set to core.setBreadcrumbs()

Dosant · 2023-10-23T09:45:13Z

@elasticmachine merge upstream

cnasikas · 2023-10-23T09:57:34Z

I see! Thanks @Dosant. We will take care of this difference in the texts.

sebelga

Overall looks good to me, just one change on where the conditional statement should be placed

sebelga · 2023-10-23T09:50:55Z

packages/shared-ux/chrome/navigation/src/ui/default_navigation.tsx

@@ -194,6 +194,7 @@ export const DefaultNavigation: FC<ProjectNavigationDefinition & Props> = ({
        }

        if (isGroupDefinition(navNode)) {
+          if (navNode.sideNavStatus === 'hidden') return null;


This should not be here. Remember that all the definition prop can also be added to the components (if the consumer decide to build the tree with UI components), so Navigation.Group in this case.

You need to add this if statement here:
https://github.com/elastic/kibana/blob/main/packages/shared-ux/chrome/navigation/src/ui/components/navigation_group.tsx#L84

thanks Seb! I moved the condition

sebelga · 2023-10-23T09:52:57Z

packages/shared-ux/chrome/navigation/src/ui/hooks/use_init_navnode.ts

@@ -59,7 +59,7 @@ function getNodeStatus(
    if (!hasUserAccessToCloudLink()) return 'remove';
  }

-  if (deepLink && deepLink.hidden) return 'remove';
+  if (deepLink && deepLink.hidden) return 'hidden';


sebelga

LGTM! 👍

kibana-ci · 2023-10-23T14:10:25Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 0fde45f

Failed CI Steps

Serverless Osquery Cypress Tests #3

Test Failures

[job] [logs] Serverless Osquery Cypress Tests #3 / ALL - Live Query should run multiline query should run multiline query

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolutionServerless`	333.2KB	333.2KB	+50.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`serverlessObservability`	59.7KB	59.8KB	+170.0B
`serverlessSearch`	46.2KB	46.3KB	+50.0B
total			+220.0B

History

💔 Build #169478 failed 41e2a38

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

## Summary fixes #169213 This PR updates route and deeplink breadcrumb from `Configure cases ` to `Settings`. It also updates bread crumb text for serverless as mentioned in #169401 (review) ![image](https://github.com/elastic/kibana/assets/117571355/94b8a0b8-9842-4570-a2e0-fd7c9b42bcb4) ![image](https://github.com/elastic/kibana/assets/117571355/65666e53-1b61-4088-bf65-87fef6dd70bd) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Summary fixes elastic#169213 This PR updates route and deeplink breadcrumb from `Configure cases ` to `Settings`. It also updates bread crumb text for serverless as mentioned in elastic#169401 (review) ![image](https://github.com/elastic/kibana/assets/117571355/94b8a0b8-9842-4570-a2e0-fd7c9b42bcb4) ![image](https://github.com/elastic/kibana/assets/117571355/65666e53-1b61-4088-bf65-87fef6dd70bd) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 68b2e4d) # Conflicts: # x-pack/test_serverless/functional/test_suites/observability/navigation.ts

improve oblt case breadcrumbs

41e2a38

Dosant changed the title ~~improve oblt case breadcrumbs~~ [Serverless] Improve cases breadcrumbs in oblt project Oct 19, 2023

Dosant requested a review from cnasikas October 19, 2023 14:01

Dosant commented Oct 19, 2023

View reviewed changes

Dosant requested a review from sebelga October 19, 2023 14:07

Dosant marked this pull request as ready for review October 19, 2023 14:08

Dosant requested review from a team as code owners October 19, 2023 14:08

cnasikas reviewed Oct 19, 2023

View reviewed changes

Merge branch 'main' into d/2023-10-19-case-oblt-breadcrumbs

74afc5d

sebelga reviewed Oct 23, 2023

View reviewed changes

move condition to component

0fde45f

Dosant requested a review from sebelga October 23, 2023 12:38

sebelga approved these changes Oct 23, 2023

View reviewed changes

js-jankisalvi mentioned this pull request Oct 23, 2023

[Cases] Update configure cases breadcrumb to settings #169532

Merged

2 tasks

Dosant merged commit b7e2893 into elastic:main Oct 23, 2023
34 checks passed

kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Serverless] Improve cases breadcrumbs in oblt project #169401

[Serverless] Improve cases breadcrumbs in oblt project #169401

Dosant commented Oct 19, 2023 •

edited

Loading

Dosant Oct 19, 2023 •

edited

Loading

sebelga Oct 23, 2023

elasticmachine commented Oct 19, 2023

cnasikas left a comment •

edited

Loading

Dosant commented Oct 23, 2023

Dosant commented Oct 23, 2023

cnasikas commented Oct 23, 2023 •

edited

Loading

sebelga left a comment

sebelga Oct 23, 2023 •

edited

Loading

Dosant Oct 23, 2023

sebelga Oct 23, 2023

sebelga left a comment

kibana-ci commented Oct 23, 2023

[Serverless] Improve cases breadcrumbs in oblt project #169401

[Serverless] Improve cases breadcrumbs in oblt project #169401

Conversation

Dosant commented Oct 19, 2023 • edited Loading

Summary

Dosant Oct 19, 2023 • edited Loading

Choose a reason for hiding this comment

sebelga Oct 23, 2023

Choose a reason for hiding this comment

elasticmachine commented Oct 19, 2023

cnasikas left a comment • edited Loading

Choose a reason for hiding this comment

Dosant commented Oct 23, 2023

Dosant commented Oct 23, 2023

cnasikas commented Oct 23, 2023 • edited Loading

sebelga left a comment

Choose a reason for hiding this comment

sebelga Oct 23, 2023 • edited Loading

Choose a reason for hiding this comment

Dosant Oct 23, 2023

Choose a reason for hiding this comment

sebelga Oct 23, 2023

Choose a reason for hiding this comment

sebelga left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 23, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Dosant commented Oct 19, 2023 •

edited

Loading

Dosant Oct 19, 2023 •

edited

Loading

cnasikas left a comment •

edited

Loading

cnasikas commented Oct 23, 2023 •

edited

Loading

sebelga Oct 23, 2023 •

edited

Loading