Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Fix frame group ID when source filename is empty #168905

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[Profiling] Fix frame group ID when source filename is empty #168905

merged 1 commit into from
Oct 18, 2023

Conversation

jbcrail
Copy link
Contributor

@jbcrail jbcrail commented Oct 14, 2023

This PR addresses an issue identified after the port from Kibana in elastic/elasticsearch#99091:

  • update createFrameGroupID to use fileID+functionName in ID instead of exeFilename+functionName if the source filename is empty

@jbcrail jbcrail added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting ci:build-cloud-image v8.12.0 labels Oct 14, 2023
@jbcrail jbcrail requested a review from a team as a code owner October 14, 2023 02:19
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

cauemarcondes
cauemarcondes approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbcrail
Fix frame group ID when source filename is empty
9753bbf 
We now use file ID and function name.
@jbcrail jbcrail force-pushed the update-frame-group-id branch from b14f75e to 9753bbf Compare October 17, 2023 02:04
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

  • 💔 Build #167968 failed b14f75e76c3a771c793f3810112ac15a4ddfdbe1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbcrail jbcrail merged commit 35038c1 into elastic:main Oct 18, 2023
@jbcrail jbcrail deleted the update-frame-group-id branch October 18, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:build-cloud-image release_note:skip Skip the PR/issue when compiling release notes v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbcrail @apmmachine @kibana-ci @cauemarcondes