-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions] Expose getAllSystemActions
from the actions client
#167783
[Actions] Expose getAllSystemActions
from the actions client
#167783
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
@elasticmachine merge upstream |
/** | ||
* Get all system connectors | ||
*/ | ||
public async getAllSystemActions(): Promise<FindConnectorResult[]> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the things this method returns are connectors.
Should this be getAllSystemConnectors
or getAllSystemActionConnectors
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right! My brain is wired to the old terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 6324edc
(#167783)
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR exposed the
getAllSystemActions
from the actions client. It will return all registered system actions. This functionality is needed by the rules client to determine if an action is a system action based on the connector ID.Checklist
Delete any items that are not applicable to this PR.
For maintainers