Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] Expose getAllSystemActions from the actions client #167783

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Oct 2, 2023

Summary

This PR exposed the getAllSystemActions from the actions client. It will return all registered system actions. This functionality is needed by the rules client to determine if an action is a system action based on the connector ID.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/Framework Issues related to the Actions Framework labels Oct 2, 2023
@cnasikas cnasikas requested a review from a team as a code owner October 2, 2023 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas
Copy link
Member Author

cnasikas commented Oct 2, 2023

@elasticmachine merge upstream

/**
* Get all system connectors
*/
public async getAllSystemActions(): Promise<FindConnectorResult[]> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the things this method returns are connectors.
Should this be getAllSystemConnectors or getAllSystemActionConnectors ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! My brain is wired to the old terminology.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 2, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #5 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies/{agentPolicyId}/copy should copy tamper protection
  • [job] [logs] FTR Configs #5 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies/{agentPolicyId}/copy should copy tamper protection

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
actions 263 265 +2
Unknown metric groups

API count

id before after diff
actions 269 271 +2

ESLint disabled line counts

id before after diff
actions 23 25 +2

Total ESLint disabled count

id before after diff
actions 25 27 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnasikas cnasikas merged commit d5f1791 into elastic:system_actions_mvp Oct 3, 2023
18 of 22 checks passed
@cnasikas cnasikas deleted the sa_expose_get_all_sa branch October 3, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions/Framework Issues related to the Actions Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants