Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interactive Setup UI never reaches Finished state #165273

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Fix interactive Setup UI never reaches Finished state #165273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b76b6a3
Fix detection logic when Kibana has booted successfully
thomheymann Aug 30, 2023
88cd553
Merge branch 'main' into fix-post-interactive-setup-redirect
thomheymann Aug 31, 2023
c92ccc3
Merge branch 'main' into fix-post-interactive-setup-redirect
thomheymann Aug 31, 2023
7619d40
Add missing api keys functional tests
thomheymann Aug 31, 2023
5168a44
Merge branch 'fix-post-interactive-setup-redirect' of https://github.…
thomheymann Aug 31, 2023
e6702bf
Update api key tests for serverless
thomheymann Aug 31, 2023
f5af960
Merge branch 'main' of https://github.com/elastic/kibana into fix-pos…
thomheymann Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/plugins/interactive_setup/public/progress_indicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,7 @@ function isKibanaPastPreboot(response?: Response, body?: StatusResponse) {
if (!response?.headers.get('content-type')?.includes('application/json')) {
return false;
}

return (
// Status endpoint may require authentication after `preboot` stage.
response?.status === 401 ||
// We're only interested in the availability of the critical core services.
(body?.status?.core?.elasticsearch?.level === 'available' &&
body?.status?.core?.savedObjects?.level === 'available')
);
return body?.status?.overall?.level === 'available';
}

export const ProgressIndicator: FunctionComponent<ProgressIndicatorProps> = ({ onSuccess }) => {
Expand Down
1 change: 1 addition & 0 deletions x-pack/test_serverless/functional/test_suites/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export default function ({ loadTestFile }: FtrProviderContext) {
loadTestFile(require.resolve('./management'));

// platform security
loadTestFile(require.resolve('./security/api_keys'));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test suite was added as part of #164886 but was not referenced correctly so never got executed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

loadTestFile(require.resolve('./security/navigation/avatar_menu'));

// Management
Expand Down
Loading