Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Add rule on click handler to global rule event log list #165179

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[RAM] Add rule on click handler to global rule event log list #165179

merged 1 commit into from
Aug 30, 2023

Conversation

JiaweiWu
Copy link
Contributor

Summary

Adds the ability to let the implementer of the global rule event log list override the default behaviour of clicking on a rule name. This might be useful for o11y since they will have their own rule details page.

Checklist

@JiaweiWu JiaweiWu added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.11.0 labels Aug 29, 2023
@JiaweiWu JiaweiWu requested a review from a team as a code owner August 29, 2023 23:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +146.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jcger
jcger approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jcger jcger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@jcger jcger merged commit 030fa9e into elastic:main Aug 30, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 30, 2023
XavierM added a commit that referenced this pull request Aug 31, 2023
@XavierM
Revert "[RAM] Add rule on click handler to global rule event log list (…
9c94abf 
…#165179)"

This reverts commit 030fa9e.
@XavierM XavierM mentioned this pull request Aug 31, 2023
Merged
XavierM added a commit that referenced this pull request Aug 31, 2023
@XavierM
Revert "[RAM] Add rule on click handler to global rule event log list" (
5ae86ee 
#165332)

Reverts #165179

because of this PR #165115, we do
not need these changes anymore. Let's remove it to avoid confusion on
the props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcger jcger jcger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JiaweiWu @elasticmachine @kibana-ci @jcger @kibanamachine