feat(slo): enhance search field selectors #165122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
added
release_note:skip
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
|
The interface Props {
index?: string,
placeholder?: string,
label: ReactNode
}That way we know the behavior between the two will always be consistent and if we find a bug we won't have to fix it in both places? Also it will make it easier to add the next field selector in the future. @kdelemme Thoughts? |
simianhacker
approved these changes
Aug 31, 2023
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kdelemme |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Sep 29, 2023
(cherry picked from commit 8c8e974)
kdelemme
added a commit
that referenced
this pull request
Sep 29, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [feat(slo): enhance search field selectors (#165122)](#165122) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-08-31T20:09:02Z","message":"feat(slo): enhance search field selectors (#165122)","sha":"8c8e9741cdb7d83371d51dbee8e2c80cff21b31f","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team: Actionable Observability","v8.11.0"],"number":165122,"url":"https://github.com/elastic/kibana/pull/165122","mergeCommit":{"message":"feat(slo): enhance search field selectors (#165122)","sha":"8c8e9741cdb7d83371d51dbee8e2c80cff21b31f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165122","number":165122,"mergeCommit":{"message":"feat(slo): enhance search field selectors (#165122)","sha":"8c8e9741cdb7d83371d51dbee8e2c80cff21b31f"}}]}] BACKPORT-->
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #165123
Summary
This PR enhances the search experience on both partition by and timestamp field selectors.
It also extract the timestamp field selector into its own component.
Recording
partition_by.and.timestamp.field.selector.search.mov