[plugin] Handle Kibana package dependencies #16509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjoar
added
WIP
kimjoar
force-pushed
the
platform/plugin-project-dependencies
branch
3 times, most recently
from
689caea to
3a54856
Compare
14 tasks
kimjoar
force-pushed
the
platform/plugin-project-dependencies
branch
3 times, most recently
from
17d3843 to
d25a113
Compare
💚 Build Succeeded |
spalger
approved these changes
Feb 8, 2018
kimjoar
force-pushed
the
platform/plugin-project-dependencies
branch
from
3f822f4 to
0935438
Compare
kimjoar
force-pushed
the
platform/plugin-project-dependencies
branch
from
0935438 to
ccc3af0
Compare
kimjoar
force-pushed
the
platform/plugin-project-dependencies
branch
from
ccc3af0 to
b3ec99f
Compare
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
kimjoar
added a commit
to kimjoar/kibana
that referenced
this pull request
Feb 12, 2018
* [plugin] Handle Kibana package dependencies * Clean up 'link:' dep check in plugin installer * Tests for 'prepareProjectDependencies' * Remove unnecessary fn from 'prepareProjectDependencies' * Move prepareProjectDependencies into @kbn/build * update snapshot * Move test to Jest * clarification
kimjoar
added a commit
that referenced
this pull request
Feb 12, 2018
* [plugin] Handle Kibana package dependencies * Clean up 'link:' dep check in plugin installer * Tests for 'prepareProjectDependencies' * Remove unnecessary fn from 'prepareProjectDependencies' * Move prepareProjectDependencies into @kbn/build * update snapshot * Move test to Jest * clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simplified version of #16481 that only handles Kibana packages (so Kibana plugins can rely on Kibana's packages, but can't yet use
link:for other dependencies)Here's an example of a minimal Kibana plugin (my-kbn-plugin-0.0.0.zip) that can be used to test this change.
To test this, first build Kibana (
yarn build --skip-archives --skip-os-packages), then cd intobuild/kibana-...for your architecture, then run:and you should see something like this in the output when starting the Kibana server:
(you'll see it during optimize after plugin install, as optimize starts the kibana server)
You should see this when starting up on server, when the api endpoint is hit, and when opening the plugin in the ui.