Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud links in serverless.yml #161534

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Jul 10, 2023

This is a follow up of #159419

To be able to see the links in cloud we need to add the urls in the kibana.yml.
This PR adds the link for the user profile menu

Screenshot 2023-06-26 at 15 39 43

@sebelga sebelga added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release Project:Serverless MVP labels Jul 10, 2023
@sebelga sebelga self-assigned this Jul 10, 2023
@sebelga sebelga marked this pull request as ready for review July 10, 2023 10:01
@sebelga sebelga requested a review from a team as a code owner July 10, 2023 10:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Jul 10, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that we will need to remove those settings from the config once the values are properly injected from Cloud

@sebelga
Copy link
Contributor Author

sebelga commented Jul 11, 2023

Thanks for the review @pgayvallet

Good point, we'll need those injected from Cloud 👍

@sebelga sebelga merged commit 31c081a into elastic:main Jul 11, 2023
@sebelga sebelga deleted the add-cloud-links branch July 11, 2023 08:23
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Serverless MVP Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants