[SLO] Support filters for good/total custom metrics #161308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
simianhacker
added
release_note:enhancement
v8.10.0
Team: Actionable Observability - DEPRECATED
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
kdelemme
approved these changes
Jul 6, 2023
| @@ -82,7 +89,7 @@ export class MetricCustomTransformGenerator extends TransformGenerator { | |||
|
|
|||
| private buildMetricEquation(type: 'good' | 'total', metricDef: MetricCustomMetricDef) { | |||
| const bucketsPath = metricDef.metrics.reduce( | |||
| (acc, metric) => ({ ...acc, [metric.name]: `_${type}_${metric.name}` }), | |||
| (acc, metric) => ({ ...acc, [metric.name]: `_${type}_${metric.name}>sum` }), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for applying a KQL filter to the good/total metrics.