Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Rename security solution plugins #161153

Merged
merged 17 commits into from
Jul 5, 2023
Merged

[SecuritySolution] Rename security solution plugins #161153

merged 17 commits into from
Jul 5, 2023

Conversation

semd
Copy link
Contributor

@semd semd commented Jul 4, 2023 •
edited
Loading

Summary

closes: #159685

  • Renaming x-pack/plugins:
    serverless_security -> security_solution_serverless
    ess_security -> security_solution_ess

  • All the related configurations and types have also been renamed.

  • i18n translation prefixes updated

  • relocation of internal security_solution_serverless directories to be consistent with security_solution_ess

Eslint

I also added the plugins in the .eslintrc configuration, defining the same rules as the security_solution plugin.
All eslint errors have been addressed (mainly type imports errors)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Documentation preview:

@semd semd self-assigned this Jul 4, 2023
@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0 labels Jul 4, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Explore - Security Solution Tests #2 / Entity Analytics Dashboard With anomalies data enables a job
  • [job] [logs] Explore - Security Solution Tests #2 / Hover actions Adds to timeline

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
essSecurity 15 - -15
securitySolutionEss - 15 +15
securitySolutionServerless - 202 +202
serverlessSecurity 262 - -262
total -60

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
essSecurity 6 - -6
securitySolution 130 132 +2
securitySolutionEss - 6 +6
securitySolutionServerless - 6 +6
serverlessSecurity 6 - -6
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
essSecurity 5.0KB - -5.0KB
securitySolutionEss - 5.1KB +5.1KB
securitySolutionServerless - 67.2KB +67.2KB
serverlessSecurity 277.9KB - -277.9KB
total -210.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
essSecurity 4.0KB - -4.0KB
securitySolution 53.2KB 53.3KB +90.0B
securitySolutionEss - 4.1KB +4.1KB
securitySolutionServerless - 20.5KB +20.5KB
serverlessSecurity 20.5KB - -20.5KB
total +222.0B
Unknown metric groups

API count

id before after diff
essSecurity 6 - -6
securitySolution 174 176 +2
securitySolutionEss - 6 +6
securitySolutionServerless - 6 +6
serverlessSecurity 6 - -6
total +2

async chunk count

id before after diff
essSecurity 1 - -1
securitySolutionEss - 1 +1
securitySolutionServerless - 6 +6
serverlessSecurity 6 - -6
total -0

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
essSecurity 5 - -5
securitySolution 410 414 +4
securitySolutionEss - 5 +5
securitySolutionServerless - 8 +8
serverlessSecurity 9 - -9
total +5

miscellaneous assets size

id before after diff
essSecurity 2.0MB - -2.0MB
securitySolutionEss - 2.0MB ⚠️ +2.0MB
securitySolutionServerless - 740.5KB ⚠️ +740.5KB
serverlessSecurity 740.5KB - -740.5KB
total -0.0B

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
essSecurity 5 - -5
securitySolution 489 493 +4
securitySolutionEss - 5 +5
securitySolutionServerless - 8 +8
serverlessSecurity 9 - -9
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd marked this pull request as ready for review July 4, 2023 18:57
@semd semd requested review from a team as code owners July 4, 2023 18:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

machadoum
machadoum approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a huge change! Thank you!

config/serverless.security.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should this file be called serverless.security_solution? 🤷‍♂️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but this file is coupled with the project type, and inside the Kibana Core the "SecuritySolution" serverless project type is called "security" everywhere, changing that would be out of the scope of this task.

x-pack/plugins/security_solution_serverless/public/upselling/register_upsellings.test.tsx
{ product_line: ProductLine.security, product_tier: 'complete' },
{ product_line: ProductLine.endpoint, product_tier: 'complete' },
{ product_line: ProductLine.cloud, product_tier: 'complete' },
{ product_line: ProductLine.security, product_tier: ProductTier.complete },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

x-pack/plugins/security_solution_serverless/public/get_started/sections.tsx
@@ -61,7 +60,7 @@ export const sections: Section[] = [
id: GetSetUpCardId.introduction,
steps: introductionSteps,
timeInMins: introductionSteps.reduce(
(totalMin, { timeInMinutes }) => (totalMin += timeInMinutes),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+= inside a reduce is very weird... Thanks for cleaning it!

@semd semd merged commit f2e773d into elastic:main Jul 5, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 5, 2023
@pgayvallet pgayvallet mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machadoum machadoum machadoum approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees

@semd semd

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Rename offering specific plugins
7 participants
@semd @kibana-ci @elasticmachine @machadoum @pgayvallet @Ikuni17 @kibanamachine