-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Disable proxies feature in serverless #160317
[Fleet] Disable proxies feature in serverless #160317
Conversation
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in core_plugins/rendering.ts
LGTM.
P.S. Off-topic, I'm curious why we use both enable
- (xpack.fleet.agents.enabled
, xpack.fleet.enableExperimental
, any-plugin.enabled
) and disable
-naming convention (xpack.fleet.internal.disableProxies
, pack.fleet.internal.disableILMPolicies
) at the same time (we can pick either true
or false
as a default value if we need to) 🙂
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nchaulet |
Yes I think we should probably harmonize that at some point, we are using disable* something for things where we want to opt-out that are enabled by default but it probably can be changed/fixed in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to config/serverless.yml
LGTM.
Summary
Disable proxies in serverless, in the UI settings and in the APIs.
UI Changes
Remove the proxy section
