Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Disable proxies feature in serverless #160317

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jun 22, 2023

Summary

Disable proxies in serverless, in the UI settings and in the APIs.

UI Changes

Remove the proxy section
Screenshot 2023-06-22 at 3 08 15 PM

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 22, 2023
@nchaulet nchaulet self-assigned this Jun 22, 2023
@nchaulet nchaulet requested a review from a team as a code owner June 22, 2023 19:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet nchaulet requested review from a team as code owners June 23, 2023 13:41
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in core_plugins/rendering.ts LGTM.

P.S. Off-topic, I'm curious why we use both enable- (xpack.fleet.agents.enabled, xpack.fleet.enableExperimental, any-plugin.enabled) and disable-naming convention (xpack.fleet.internal.disableProxies, pack.fleet.internal.disableILMPolicies) at the same time (we can pick either true or false as a default value if we need to) 🙂

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 973.3KB 973.5KB +141.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet
Copy link
Member Author

P.S. Off-topic, I'm curious why we use both enable- (xpack.fleet.agents.enabled, xpack.fleet.enableExperimental, any-plugin.enabled) and disable-naming convention (xpack.fleet.internal.disableProxies, pack.fleet.internal.disableILMPolicies) at the same time (we can pick either true or false as a default value if we need to) 🙂

Yes I think we should probably harmonize that at some point, we are using disable* something for things where we want to opt-out that are enabled by default but it probably can be changed/fixed in the future.

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to config/serverless.yml LGTM.

@nchaulet nchaulet merged commit c3b8ed2 into elastic:main Jun 23, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jun 23, 2023
@nchaulet nchaulet deleted the feature-disable-proxies-serverless branch June 23, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants