Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event annotations] Lens design improvements #159057

Merged
merged 14 commits into from
Jul 3, 2023
Merged

[Event annotations] Lens design improvements #159057

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f4a76df
remove custom empty button label for annotations
drewdaemon Jun 5, 2023
1cebef8
vertically position annotation saved object finder
drewdaemon Jun 5, 2023
8d251cd
fix icon size
drewdaemon Jun 5, 2023
defdbcb
string changes
drewdaemon Jun 5, 2023
05da4d5
improve saved object save modal flex structure
drewdaemon Jun 5, 2023
a6af3c0
add more padding to unsaved indicator
drewdaemon Jun 5, 2023
847367a
better title validation
drewdaemon Jun 5, 2023
9b9d92c
update remove layer modal text
drewdaemon Jun 29, 2023
71b9879
Merge branch 'main' of github.com:elastic/kibana into 158779/annotati…
drewdaemon Jun 29, 2023
d2fc144
duplicate title checking
drewdaemon Jun 30, 2023
2168720
fix CI
drewdaemon Jun 30, 2023
184f8bc
remove padding
drewdaemon Jun 30, 2023
9f49d43
Remove toast TTL
drewdaemon Jun 30, 2023
d58a4cc
Merge branch 'main' into 158779/annotations-design-feedback
stratoula Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix CI
  • Loading branch information
@drewdaemon
drewdaemon committed Jun 30, 2023
commit 2168720bec84b488d74af49765590b250d3b0464
288 changes: 144 additions & 144 deletions ...ugins/saved_objects/public/save_modal/__snapshots__/saved_object_save_modal.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions x-pack/plugins/lens/public/visualizations/xy/xy_config_panel/layer_header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
import { ToolbarButton } from '@kbn/kibana-react-plugin/public';
import { IconChartBarReferenceLine, IconChartBarAnnotations } from '@kbn/chart-icons';
import { euiThemeVars } from '@kbn/ui-theme';
import { css } from '@emotion/react';
import { getIgnoreGlobalFilterIcon } from '../../../shared_components/ignore_global_filter/data_view_picker_icon';
import type {
VisualizationLayerHeaderContentProps,
Expand Down
4 changes: 1 addition & 3 deletions x-pack/plugins/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20080,7 +20080,6 @@
"xpack.lens.functions.timeScale.dateColumnMissingMessage": "L'ID de colonne de date spécifié {columnId} n'existe pas.",
"xpack.lens.heatmapVisualization.arrayValuesWarningMessage": "{label} contient des valeurs de tableau. Le rendu de votre visualisation peut ne pas se présenter comme attendu.",
"xpack.lens.indexPattern.addColumnAriaLabel": "Ajouter ou faire glisser un champ vers {groupLabel}",
"xpack.lens.indexPattern.addColumnAriaLabelClick": "Ajouter une annotation à {groupLabel}",
"xpack.lens.indexPattern.annotationsDimensionEditorLabel": "Annotation {groupLabel}",
"xpack.lens.indexPattern.ascendingCountPrecisionErrorWarning": "{name} pour cette visualisation peut être approximatif en raison de la manière dont les données sont indexées. Essayez de trier par rareté plutôt que par nombre ascendant d’enregistrements. Pour en savoir plus sur cette limitation, {link}.",
"xpack.lens.indexPattern.autoIntervalLabel": "Auto ({interval})",
Expand Down Expand Up @@ -20315,7 +20314,6 @@
"xpack.lens.configPanel.selectVisualization": "Sélectionner une visualisation",
"xpack.lens.configPanel.visualizationType": "Type de visualisation",
"xpack.lens.configure.emptyConfig": "Ajouter ou glisser-déposer un champ",
"xpack.lens.configure.emptyConfigClick": "Ajouter une annotation",
"xpack.lens.configure.invalidBottomReferenceLineDimension": "La ligne de référence est affectée à un axe qui n’existe plus ou qui n’est plus valide. Vous pouvez déplacer cette ligne de référence vers un autre axe disponible ou la supprimer.",
"xpack.lens.configure.invalidConfigTooltip": "Configuration non valide.",
"xpack.lens.configure.invalidConfigTooltipClick": "Cliquez pour en savoir plus.",
Expand Down Expand Up @@ -39440,4 +39438,4 @@
"xpack.painlessLab.title": "Painless Lab",
"xpack.painlessLab.walkthroughButtonLabel": "Présentation"
}
}
}
Loading