Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Sourcerer] Remove api data from intial state, add middleware for initialization #158637

Conversation

kqualters-elastic
Copy link
Contributor

@kqualters-elastic kqualters-elastic commented May 30, 2023

Summary

This pr changes nothing about how the app functions from a user perspective, except that the security solution store is not blocked from creation by these api calls anymore, just moves the network requests made to seed the sourcerer initial state from the createStore part of the app, to a a new custom middleware, enabling developers to see how the response changed the actual initial state.

Checklist

Delete any items that are not applicable to this PR.

@kqualters-elastic kqualters-elastic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team labels May 30, 2023
@kqualters-elastic kqualters-elastic requested a review from a team as a code owner May 30, 2023 02:20
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 30, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #1 / Create DataView runtime field adds field to alert table
  • [job] [logs] Security Solution Tests #1 / Create DataView runtime field adds field to alert table
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a $ip$ with a null query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a $ip$ with a null query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a $ip$ with a value for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a $ip$ with a value for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a host name with a variable in the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a host name with a variable in the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a multiple host names with a value for query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a multiple host names with a value for query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a multiple host names with null for query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a multiple host names with null for query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a multiple IPs with a null for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a multiple IPs with a null for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a multiple IPs with a value for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a multiple IPs with a value for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a single host name with a null for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a single host name with a null for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a single host name with a value for query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a single host name with a value for query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a single IP with a null for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a single IP with a null for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a single IP with a value for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a single IP with a value for the query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a undefined/null host name but with a value for query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a undefined/null host name but with a value for query
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a undefined/null host name with a null for the KQL
  • [job] [logs] Security Solution Tests #3 / ml conditional links redirects from a undefined/null host name with a null for the KQL
  • [job] [logs] Investigations - Security Solution Tests #3 / Open timeline Open timeline modal should open a modal
  • [job] [logs] Investigations - Security Solution Tests #3 / Open timeline Open timeline modal should open a modal
  • [job] [logs] Security Solution Tests #1 / Sourcerer Default scope Modified badge Selecting new data view does not add a modified badge
  • [job] [logs] Security Solution Tests #1 / Sourcerer Default scope Modified badge Selecting new data view does not add a modified badge
  • [job] [logs] Security Solution Tests #1 / Timeline scope Alerts checkbox shows alerts badge when index patterns change and removes when reset
  • [job] [logs] Security Solution Tests #1 / Timeline scope Alerts checkbox shows alerts badge when index patterns change and removes when reset
  • [job] [logs] Security Solution Tests #1 / Timeline scope Modified badge Selecting new data view does not add a modified badge
  • [job] [logs] Security Solution Tests #4 / url state sets KQL in host page and detail page and check if href match on breadcrumb, tabs and subTabs
  • [job] [logs] Security Solution Tests #4 / url state sets KQL in host page and detail page and check if href match on breadcrumb, tabs and subTabs
  • [job] [logs] Security Solution Tests #4 / url state sets the url state when kql is set and check if href reflect this change
  • [job] [logs] Security Solution Tests #4 / url state sets the url state when kql is set and check if href reflect this change
  • [job] [logs] Jest Integration Tests #1 / when rendering the endpoint list AdminSearchBar should not reset the page_index if query unchanged
  • [job] [logs] Jest Integration Tests #1 / when rendering the endpoint list AdminSearchBar should pre-populate with value from url
  • [job] [logs] Jest Integration Tests #1 / when rendering the endpoint list AdminSearchBar should reset the page_index to zero if query changes
  • [job] [logs] Jest Integration Tests #1 / when rendering the endpoint list AdminSearchBar should update the url and exclude the admin_query param when nothing was entered
  • [job] [logs] Jest Integration Tests #1 / when rendering the endpoint list AdminSearchBar should update the url and exclude the admin_query param when spaces was entered
  • [job] [logs] Jest Integration Tests #1 / when rendering the endpoint list AdminSearchBar should update the url with the admin_query param if a query was entered

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3908 3909 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.2MB 9.2MB +636.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 401 405 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 481 485 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants