-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [Sourcerer] Remove api data from intial state, add middleware for initialization #158637
Closed
kqualters-elastic
wants to merge
1
commit into
elastic:main
from
kqualters-elastic:sourcerer-initial-state-middleware
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqualters-elastic
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting:Investigations
Security Solution Investigations Team
labels
May 30, 2023
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
HistoryTo update your PR or re-run it, just comment with: |
lgestc
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
michaelolo24
added
the
technical debt
Improvement of the software architecture and operational architecture
label
May 30, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting:Investigations
Security Solution Investigations Team
technical debt
Improvement of the software architecture and operational architecture
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr changes nothing about how the app functions from a user perspective, except that the security solution store is not blocked from creation by these api calls anymore, just moves the network requests made to seed the sourcerer initial state from the createStore part of the app, to a a new custom middleware, enabling developers to see how the response changed the actual initial state.
Checklist
Delete any items that are not applicable to this PR.