-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] Versioning transforms APIs #158273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Versioning transforms APIs #158273
Conversation
|
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/transform/public/app/services/es_index_service.ts
Outdated
Show resolved
Hide resolved
| .addVersion( | ||
| { | ||
| version: '1', | ||
| validate: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Since we are not validating here, we can change this to validate: false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't 100% sure if validate: {} is identical to validate: false so left this with no changes.
But it's very low risk, so I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in e8cfb92
peteharverson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
ElenaStoeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to shared useRequest and sendRequest functions LGTM.
Adds versioning to all of the transform APIs.
Versions are added to the server side routes and to the client side functions which call the routes.
Updates API tests to add the API version to the request headers.
All of the APIs are internal and have been given the version '1'.
Internal APIs
/internal/transform/privileges/internal/transform/field_histograms/{dataViewTitle}/internal/transform/privileges/internal/transform/transforms/{transformId}/messages/internal/transform/transforms/_nodes/internal/transform/transforms/internal/transform/transforms/{transformId}/internal/transform/transforms/_stats/internal/transform/transforms/{transformId}/_stats/internal/transform/transforms/{transformId}/internal/transform/transforms/{transformId}/_update/internal/transform/reauthorize_transforms/internal/transform/delete_transforms/internal/transform/reset_transforms/internal/transform/transforms/_preview/internal/transform/start_transforms/internal/transform/stop_transforms/internal/transform/schedule_now_transforms