Skip to content

Conversation

@jgowdyelastic
Copy link
Member

Adds versioning to all of the transform APIs.
Versions are added to the server side routes and to the client side functions which call the routes.
Updates API tests to add the API version to the request headers.

All of the APIs are internal and have been given the version '1'.

Internal APIs

/internal/transform/privileges
/internal/transform/field_histograms/{dataViewTitle}
/internal/transform/privileges
/internal/transform/transforms/{transformId}/messages
/internal/transform/transforms/_nodes
/internal/transform/transforms
/internal/transform/transforms/{transformId}
/internal/transform/transforms/_stats
/internal/transform/transforms/{transformId}/_stats
/internal/transform/transforms/{transformId}
/internal/transform/transforms/{transformId}/_update
/internal/transform/reauthorize_transforms
/internal/transform/delete_transforms
/internal/transform/reset_transforms
/internal/transform/transforms/_preview
/internal/transform/start_transforms
/internal/transform/stop_transforms
/internal/transform/schedule_now_transforms

@jgowdyelastic jgowdyelastic self-assigned this May 23, 2023
@jgowdyelastic jgowdyelastic added release_note:enhancement non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Transforms Transforms v8.9.0 labels May 23, 2023
@jgowdyelastic jgowdyelastic marked this pull request as ready for review May 23, 2023 14:46
@jgowdyelastic jgowdyelastic requested review from a team as code owners May 23, 2023 14:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

.addVersion(
{
version: '1',
validate: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since we are not validating here, we can change this to validate: false?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't 100% sure if validate: {} is identical to validate: false so left this with no changes.
But it's very low risk, so I'll change it.

Copy link
Member Author

@jgowdyelastic jgowdyelastic May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in e8cfb92

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
esUiShared 110 111 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 387.1KB 387.5KB +426.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
esUiShared 152.4KB 152.5KB +42.0B
transform 17.7KB 17.7KB +12.0B
total +54.0B
Unknown metric groups

API count

id before after diff
esUiShared 114 115 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to shared useRequest and sendRequest functions LGTM.

@jgowdyelastic jgowdyelastic merged commit 7d93816 into elastic:main May 25, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 25, 2023
@peteharverson peteharverson added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Transforms Transforms :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.9.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants