[UnifiedSearch] Add query DSL docs link to filters UI #156543

jughosta · 2023-05-03T13:41:51Z

Summary

This PR adds a link to "Query DSL" syntax docs.

…fix'

…dsl-docs-link

elasticmachine · 2023-05-04T09:02:29Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta · 2023-05-04T09:05:37Z

.../plugins/exploratory_view/public/components/shared/filter_value_label/filter_value_label.tsx

-    services: { uiSettings },
-  } = useKibana();
+    services: { uiSettings, docLinks },
+  } = useKibana<ObservabilityAppServices>();


Uptime team, could you please please test these changes with your data set?
Btw, is it expected that components are duplicated under exploratory_view and observability plugins?

Hey there @jughosta! We just merged a PR last week that cleans up these duplicates (#157970). Could you pull in main? If there's more duplicates please file an issue with us (Actionable Observability).

davismcphee

My review wasn't requested here, but I'm nosy and just wanted to leave a quick comment about some copy 😅 Otherwise LGTM, seems like a useful link to include here 👍

src/plugins/unified_search/public/filter_bar/filter_editor/filter_editor.tsx

…ter_editor.tsx Co-authored-by: Davis McPhee <davismcphee@hotmail.com>

stratoula

Very nice addition Julia, LGTM!

shahzad31

Uptime changes LGTM !!

CoenWarmer

Thanks for this! Just some comments related to a change we made just as you were working on your PR.

CoenWarmer · 2023-05-22T07:16:17Z

.../plugins/exploratory_view/public/components/shared/filter_value_label/filter_value_label.tsx

@@ -11,6 +11,7 @@ import { Filter, buildPhrasesFilter, buildPhraseFilter } from '@kbn/es-query';
 import { FilterItem } from '@kbn/unified-search-plugin/public';
 import type { DataView } from '@kbn/data-views-plugin/common';
 import { useKibana } from '@kbn/kibana-react-plugin/public';
+import { ObservabilityAppServices } from '../../../application/types';


Could you please use ObservabilityPluginStart instead? This type is a duplicate and we want to remove it with #158144.

@CoenWarmer Looks like there is no ObservabilityPluginStart in x-pack/plugins/exploratory_view. Would it be okay to keep ObservabilityAppServices for this PR?

@jughosta I mean ObservabilityPublicPluginsStart: x-pack/plugins/observability/public/plugin.ts (line 90).

I'm approving now as I am on paternity leave and don't want to block. But I would prefer if you could apply the change requested.

Hi @elastic/actionable-observability,

Could you please help me understand your code setup so I can improve the PR changes.

From my observation there are 2 ObservabilityAppServices types: in observability and in exploratory_view plugins. They include different services btw. And there is also ObservabilityPublicPluginsStart which might replace ObservabilityAppServices in observability via #158144

My change is in the second exploratory_view plugin. I am not familiar with how your code is organized in plugins and from the high level it does not seem to fit using a Kibana services type from one plugin inside another plugin (as suggested ObservabilityPublicPluginsStart from observability in exploratory_view). Also ObservabilityPublicPluginsStart does not include docLinks as it comes from core.

How would you suggest to proceed with adding docLinks for useKibana call in exploratory_view plugin?

# Conflicts: # x-pack/plugins/observability/public/components/shared/index.tsx # x-pack/plugins/observability/public/index.ts

CoenWarmer

Approve to unblock PR, but change requested. Otherwise LGTM

# Conflicts: # src/plugins/unified_search/tsconfig.json

kibana-ci · 2023-05-26T09:28:40Z

💚 Build Succeeded

Buildkite Build
Commit: 98cd09e

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`exploratoryView`	216.9KB	217.0KB	+44.0B
`unifiedSearch`	210.9KB	211.2KB	+329.0B
total			+373.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`securitySolution`	400	404	+4
total			+6

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`securitySolution`	480	484	+4
total			+6

History

💚 Build #129486 succeeded 584d6bb
💚 Build #129204 succeeded 89bb422
💛 Build #129186 was flaky 9619d79
💚 Build #128483 succeeded 14461ac
💚 Build #128171 succeeded 5c2c094
💚 Build #126088 succeeded 892e752

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

[UnifiedSearch] Add query DSL docs link to filters UI

b453fa3

jughosta added release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:Unified search Unified search related tasks labels May 3, 2023

jughosta self-assigned this May 3, 2023

jughosta added the backport:skip This commit does not require backporting label May 3, 2023

kibanamachine and others added 7 commits May 3, 2023 13:50

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

9239481

…fix'

[UnifiedSearch] Update other places

5f18d59

Merge remote-tracking branch 'origin/query-dsl-docs-link' into query-…

a2026bf

…dsl-docs-link

[UnifiedSearch] Update types

3ff4dd1

Merge branch 'main' into query-dsl-docs-link

1a05dad

[UnifiedSearch] Update types

43c3726

Merge branch 'main' into query-dsl-docs-link

64d7fa2

jughosta marked this pull request as ready for review May 4, 2023 09:02

jughosta requested review from a team as code owners May 4, 2023 09:02

jughosta commented May 4, 2023

View reviewed changes

davismcphee approved these changes May 5, 2023

View reviewed changes

src/plugins/unified_search/public/filter_bar/filter_editor/filter_editor.tsx Outdated Show resolved Hide resolved

jughosta and others added 4 commits May 8, 2023 08:56

Update src/plugins/unified_search/public/filter_bar/filter_editor/fil…

ca23f08

…ter_editor.tsx Co-authored-by: Davis McPhee <davismcphee@hotmail.com>

Merge branch 'main' into query-dsl-docs-link

892e752

Merge branch 'main' into query-dsl-docs-link

5c2c094

Merge branch 'main' into query-dsl-docs-link

d3cf054

stratoula approved these changes May 17, 2023

View reviewed changes

remove unused

14461ac

shahzad31 requested a review from a team as a code owner May 17, 2023 07:56

shahzad31 approved these changes May 17, 2023

View reviewed changes

CoenWarmer requested changes May 22, 2023

View reviewed changes

jughosta added 2 commits May 22, 2023 09:32

Merge remote-tracking branch 'upstream/main' into query-dsl-docs-link

9619d79

# Conflicts: # x-pack/plugins/observability/public/components/shared/index.tsx # x-pack/plugins/observability/public/index.ts

Merge branch 'main' into query-dsl-docs-link

89bb422

jughosta requested a review from CoenWarmer May 22, 2023 08:52

CoenWarmer approved these changes May 23, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main' into query-dsl-docs-link

584d6bb

# Conflicts: # src/plugins/unified_search/tsconfig.json

jughosta requested a review from a team May 23, 2023 09:00

fkanout approved these changes May 25, 2023

View reviewed changes

Merge branch 'main' into query-dsl-docs-link

98cd09e

jughosta merged commit ad85cc0 into elastic:main May 26, 2023

jughosta deleted the query-dsl-docs-link branch May 26, 2023 12:26

kibanamachine added the v8.9.0 label May 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UnifiedSearch] Add query DSL docs link to filters UI #156543

[UnifiedSearch] Add query DSL docs link to filters UI #156543

jughosta commented May 3, 2023

elasticmachine commented May 4, 2023

jughosta May 4, 2023

CoenWarmer May 22, 2023

davismcphee left a comment

stratoula left a comment

shahzad31 left a comment

CoenWarmer left a comment

CoenWarmer May 22, 2023

jughosta May 22, 2023

CoenWarmer May 23, 2023

jughosta May 23, 2023 •

edited

Loading

CoenWarmer left a comment

kibana-ci commented May 26, 2023

ESLint disabled line counts

Total ESLint disabled count

[UnifiedSearch] Add query DSL docs link to filters UI #156543

[UnifiedSearch] Add query DSL docs link to filters UI #156543

Conversation

jughosta commented May 3, 2023

Summary

elasticmachine commented May 4, 2023

jughosta May 4, 2023

Choose a reason for hiding this comment

CoenWarmer May 22, 2023

Choose a reason for hiding this comment

davismcphee left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

shahzad31 left a comment

Choose a reason for hiding this comment

CoenWarmer left a comment

Choose a reason for hiding this comment

CoenWarmer May 22, 2023

Choose a reason for hiding this comment

jughosta May 22, 2023

Choose a reason for hiding this comment

CoenWarmer May 23, 2023

Choose a reason for hiding this comment

jughosta May 23, 2023 • edited Loading

Choose a reason for hiding this comment

CoenWarmer left a comment

Choose a reason for hiding this comment

kibana-ci commented May 26, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

jughosta May 23, 2023 •

edited

Loading