Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup file saved object mappings #153829

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Cleanup file saved object mappings #153829

wants to merge 6 commits into from
+2 −8

Conversation

vadimkibana
Copy link
Contributor

Summary

Partially addresses #153484 for the file share saved object.

@vadimkibana vadimkibana mentioned this pull request Mar 28, 2023
Closed
6 tasks
@vadimkibana vadimkibana changed the title remove "name" and "valid_until" mappings as they don't need to be ind… Cleanup file saved object mappings Mar 28, 2023
@vadimkibana vadimkibana added review Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) feature:Files v8.8.0 labels Mar 28, 2023
@vadimkibana vadimkibana marked this pull request as ready for review March 28, 2023 09:19
@vadimkibana vadimkibana requested review from a team as code owners March 28, 2023 09:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@rudolf
Copy link
Contributor

rudolf commented Apr 19, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
fileShare 5 3 -2
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majagrubic majagrubic majagrubic approved these changes

@jloleysens jloleysens jloleysens approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature:Files Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes review Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vadimkibana @elasticmachine @rudolf @kibana-ci @majagrubic @jloleysens @kibanamachine