Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 10, 2023

Summary

This PR adds the common 404 and 401 response objects to the components section of the OAS, per https://spec.openapis.org/oas/v3.0.1#components-object. It also removes an incorrect description "Unsuccessful rule API response", since this is a connector specification.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// docs Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX v8.8.0 v8.7.1 labels Mar 10, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@kibana-ci
Copy link

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detections : Page Filters Alert Page Filters Customization Add New Controls
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detections : Page Filters Alert Page Filters Customization should not sync to the URL in edit mode but only in view mode

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review March 21, 2023 20:21
@lcawl lcawl requested a review from a team as a code owner March 21, 2023 20:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! LGTM

@lcawl lcawl merged commit 782a3d5 into elastic:main Mar 29, 2023
@lcawl lcawl deleted the connector-responeses branch March 29, 2023 02:28
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 29, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 29, 2023
…tion (#153136) (#153909)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[DOCS] Add responses components in connector open API specification
(#153136)](#153136)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-03-29T02:28:43Z","message":"[DOCS]
Add responses components in connector open API specification
(#153136)","sha":"782a3d5e4285470763acb2c20aa3407b60c6fe06","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorsManagement","v8.8.0","v8.7.1"],"number":153136,"url":"https://github.com/elastic/kibana/pull/153136","mergeCommit":{"message":"[DOCS]
Add responses components in connector open API specification
(#153136)","sha":"782a3d5e4285470763acb2c20aa3407b60c6fe06"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153136","number":153136,"mergeCommit":{"message":"[DOCS]
Add responses components in connector open API specification
(#153136)","sha":"782a3d5e4285470763acb2c20aa3407b60c6fe06"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.7.0 v8.7.1 v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants