-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[DOCS] Add responses components in connector open API specification #153136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation preview: |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
pmuellr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up! LGTM
…lastic#153136) (cherry picked from commit 782a3d5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…tion (#153136) (#153909) # Backport This will backport the following commits from `main` to `8.7`: - [[DOCS] Add responses components in connector open API specification (#153136)](#153136) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-03-29T02:28:43Z","message":"[DOCS] Add responses components in connector open API specification (#153136)","sha":"782a3d5e4285470763acb2c20aa3407b60c6fe06","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorsManagement","v8.8.0","v8.7.1"],"number":153136,"url":"https://github.com/elastic/kibana/pull/153136","mergeCommit":{"message":"[DOCS] Add responses components in connector open API specification (#153136)","sha":"782a3d5e4285470763acb2c20aa3407b60c6fe06"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153136","number":153136,"mergeCommit":{"message":"[DOCS] Add responses components in connector open API specification (#153136)","sha":"782a3d5e4285470763acb2c20aa3407b60c6fe06"}},{"branch":"8.7","label":"v8.7.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Summary
This PR adds the common 404 and 401 response objects to the components section of the OAS, per https://spec.openapis.org/oas/v3.0.1#components-object. It also removes an incorrect description "Unsuccessful rule API response", since this is a connector specification.