Skip to content

removes left over code from the gauge-metric #15142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 29, 2017
Merged

removes left over code from the gauge-metric #15142

merged 3 commits into from
Nov 29, 2017

Conversation

@ppisljar
Copy link
Contributor

@ppisljar ppisljar commented Nov 23, 2017

removes left over code from the gauge-metric

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.1.0 v7.0.0 labels Nov 23, 2017
@ppisljar ppisljar force-pushed the removeGaugeMetricLeftovers branch from 23f0e55 to 9532635 Compare November 23, 2017 09:47
@timroes
Copy link
Contributor

timroes commented Nov 23, 2017

The test failure seems relevant for this PR :)

@ppisljar ppisljar requested a review from nreese November 23, 2017 13:39
@ppisljar
Copy link
Contributor Author

ppisljar commented Nov 23, 2017

jenkins, test this

thomasneirynck
thomasneirynck approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we should probably rebase with latest master/6.1 given the recent changes there.

nreese
nreese approved these changes Nov 28, 2017
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ppisljar ppisljar force-pushed the removeGaugeMetricLeftovers branch from dc95a8a to 1590ecb Compare November 29, 2017 15:29
@ppisljar ppisljar merged commit 1bc1516 into elastic:master Nov 29, 2017
@ppisljar ppisljar mentioned this pull request Nov 29, 2017
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Nov 29, 2017
@ppisljar
removes left over code from the gauge-metric (elastic#15142)
c13bf6b 
removes left over code from the gauge-metric
@ppisljar ppisljar mentioned this pull request Nov 29, 2017
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Nov 29, 2017
@ppisljar
removes left over code from the gauge-metric (elastic#15142)
0c99a0a 
removes left over code from the gauge-metric
ppisljar added a commit that referenced this pull request Nov 29, 2017
@ppisljar
removes left over code from the gauge-metric (#15142) (#15259)
f992a66 
removes left over code from the gauge-metric
ppisljar added a commit that referenced this pull request Nov 30, 2017
@ppisljar
removes left over code from the gauge-metric (#15142) (#15258)
2ad742f 
removes left over code from the gauge-metric
@sulemanof sulemanof mentioned this pull request Aug 14, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese nreese approved these changes

+2 more reviewers

@timroes timroes timroes approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.1.0 v7.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ppisljar @timroes @nreese @thomasneirynck