-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiling] Prepare for inline stackframes #150401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an error seen in elastic/prodfiler#2939 and was discussed in elastic/prodfiler#2918. Synthetic source was removed for stackframes in elastic/prodfiler#2850.
This addresses elastic/prodfiler#2918, which prepares for stackframe inlining support.
Inline frame support requires that we can ingest array fields. However, until inline frame support is supported fully both in all write paths and the UI, we still need to handle stackframe fields that may also be single values.
This was a result of an update from elastic/prodfiler#2850.
What doesn't work for me is getting interpreter symbols from the 8.6 MVP cluster. It seems to be a regression. That is with switching
to |
I pushed a fix for this. @dgieselaar could you please have a look at it ? |
dgieselaar
approved these changes
Feb 7, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds initial support for initial stackframes as described in elastic/prodfiler#2918.
It also adds tests and a minor refactor to account for the removal of synthetic source from stackframes (see elastic/prodfiler#2850).
For reviewers
For stackframes, the profiling stack is composed of multiple write paths into Elasticsearch and multiple read paths out of Elasticsearch:
APM agent
,pf-elastic-collector
, andpf-elastic-symbolizer
).search
andmget
calls).This PR was written to handle all permutations of these paths. For those reviewers that wish to try the PR, please keep this in mind. I also wrote tests to handle these permutations.
Note: Future PRs will add full support for inline stackframes. At this time, we only read the first inlined stackframe since the UI does not support inline stackframes.