Skip to content

unskip Failing test: Chrome UI Functional Tests.test/functional/apps/visualize/input_control_vis/dynamic_options·ts #149874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

unskip Failing test: Chrome UI Functional Tests.test/functional/apps/visualize/input_control_vis/dynamic_options·ts #149874

merged 1 commit into from
Jan 30, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 30, 2023 •
edited
Loading

@nreese
unskip Failing test: Chrome UI Functional Tests.test/functional/apps/…
90192d7 
…visualize/input_control_vis/dynamic_options·ts
@kibana-ci
Copy link

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review January 30, 2023 20:25
@nreese nreese requested a review from a team as a code owner January 30, 2023 20:25
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes labels Jan 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson
ThomThomson approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like back in 2021 when this was failing it was failing roughly once per day. I assume that 50 runs would have run into at least one failure if it was still flaky.

@nreese
Copy link
Contributor Author

nreese commented Jan 30, 2023

LGTM! Looks like back in 2021 when this was failing it was failing roughly once per day. I assume that 50 runs would have run into at least one failure if it was still flaky.

and new flaky test failures will re-open the issue so we can get screen shots and logs of any new failures.

@nreese nreese merged commit 53b50c5 into elastic:main Jan 30, 2023
@kibanamachine kibanamachine added v8.7.0 backport:skip This PR does not require backporting labels Jan 30, 2023
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this pull request Feb 6, 2023
@nreese @kqualters-elastic
unskip Failing test: Chrome UI Functional Tests.test/functional/apps/…
434328c 
…visualize/input_control_vis/dynamic_options·ts (elastic#149874)

Fixes elastic#98974

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.7.0

Projects

None yet

Milestone

No milestone

5 participants

@nreese @kibana-ci @elasticmachine @ThomThomson @kibanamachine