[Maps] unskip X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/maps_integration·ts - saved objects tagging #149356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/saved_object_tagging/functional/tests/maps_integration·ts - saved objects tagging
…-ref HEAD~1..HEAD --fix'
Contributor
Author
|
@elasticmachine merge upstream |
nreese
added
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
reviewed
Jan 25, 2023
| expect(itemNames).to.contain('dashboard 4 with real data (tag-1)'); | ||
| }); | ||
|
|
||
| it('retains dashboard saved object tags after quicksave', async () => { |
Contributor
There was a problem hiding this comment.
🔥 Thanks for combining these!
vadimkibana
approved these changes
Jan 26, 2023
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
…t/saved_object_tagging/functional/tests/maps_integration·ts - saved objects tagging (elastic#149356) Fixes elastic#89073 and elastic#106547 Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1785 Issue with flaky maps_integration.ts is that there was not await when filtering maps list by tags. This resulted in list page refreshing after `const links = await this.find.allByCssSelector('.euiTableRow-isSelectable .euiLink');` and then getting an elemented unmounted on future `await links[i].getVisibleText()` calls. A [similar fix](elastic#82930) was implemented for visualize and dashboard listing pages. elastic#82930 introduced `listingTable.waitUntilTableIsLoaded` but did not introduce the method in a consistent way. Other methods that search table were not updated to use `listingTable.waitUntilTableIsLoaded`, but instead used `this.header.waitUntilLoadingHasFinished()`. This PR resolved this issue by updating all listingTable methods that search to use `listingTable.waitUntilTableIsLoaded` and then updated `listingTable.waitUntilTableIsLoaded` with a call to `this.header.waitUntilLoadingHasFinished()` elastic#82930 did not update maps_integration tests, only resolving the issue for visualize and dashboard. To avoid future situations where fixes only resolve a few usages, this PR moves selectFilterTags into listing_table and replaces all implementations of selectFilterTags with listingTable.selectFilterTags. While investigating dashboard_integrations test, I found `x-pack/test/functional/apps/dashboard/group2/dashboard_tagging.ts`, which duplicated most of dashboard_integrations test. This PR removes x-pack/test/functional/apps/dashboard/group2/dashboard_tagging.ts adds the unique test case to dashboard_integrations Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89073 and #106547
Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1785
Issue with flaky maps_integration.ts is that there was not await when filtering maps list by tags. This resulted in list page refreshing after
const links = await this.find.allByCssSelector('.euiTableRow-isSelectable .euiLink');and then getting an elemented unmounted on futureawait links[i].getVisibleText()calls.A similar fix was implemented for visualize and dashboard listing pages.
#82930 introduced
listingTable.waitUntilTableIsLoadedbut did not introduce the method in a consistent way. Other methods that search table were not updated to uselistingTable.waitUntilTableIsLoaded, but instead usedthis.header.waitUntilLoadingHasFinished(). This PR resolved this issue by updating all listingTable methods that search to uselistingTable.waitUntilTableIsLoadedand then updatedlistingTable.waitUntilTableIsLoadedwith a call tothis.header.waitUntilLoadingHasFinished()#82930 did not update maps_integration tests, only resolving the issue for visualize and dashboard. To avoid future situations where fixes only resolve a few usages, this PR moves selectFilterTags into listing_table and replaces all implementations of selectFilterTags with listingTable.selectFilterTags.
While investigating dashboard_integrations test, I found
x-pack/test/functional/apps/dashboard/group2/dashboard_tagging.ts, which duplicated most of dashboard_integrations test. This PR removes x-pack/test/functional/apps/dashboard/group2/dashboard_tagging.ts adds the unique test case to dashboard_integrations