-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17] chore(NA): updates from lmdb-store to lmdb (#145891) #149100
Conversation
This PR upgrades from `lbmd-store` into `lmdb` which is the new package and fully compatible with node `v18`. So far my tests shows the new implementation is compatible with our usages and I'm actually seeing a great performance boost when comparing with main specially on subsequent calls of the same command. This can be tested by running the following 2 times on main vs this branch `time node scripts/kibana --config src/cli/serve/integration_tests/__fixtures__/invalid_config.yml --migrations.skip=true --verbose` I verify the following on my machine **main:** _1st run:_ 36s _2nd run:_ 34s **this branch:** _1st run:_ 35s _2nd run:_ 6s Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit e65c652) # Conflicts: # package.json # packages/kbn-optimizer/BUILD.bazel # packages/kbn-optimizer/src/node/cache.ts # packages/kbn-optimizer/src/node/node_auto_tranpilation.ts # yarn.lock
@mistic I went ahead and tried to backport #145891 to |
@watson I found this comment I left back then #146647 (comment) I think to backport this into |
@mistic how much work do you think upgrading to jest 27 would be? Unfortunately we do need to upgrade the Node.js version on |
@jbudz as you were the one working on this, do you anticipate too much work to upgrade jest to v27 on 7.17? |
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @watson |
Closing in exchange of #146647 |
Backport
This will backport the following commits from
main
to7.17
:Questions ?
Please refer to the Backport tool documentation
\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/145891","number":145891,"mergeCommit":{"message":"chore(NA): updates from lmdb-store to lmdb (#145891)\n\nThis PR upgrades from `lbmd-store` into `lmdb` which is the new package\r\nand fully compatible with node `v18`.\r\nSo far my tests shows the new implementation is compatible with our\r\nusages and I'm actually seeing a great performance boost when comparing\r\nwith main specially on subsequent calls of the same command.\r\n\r\nThis can be tested by running the following 2 times on main vs this\r\nbranch `time node scripts/kibana --config\r\nsrc/cli/serve/integration_tests/__fixtures__/invalid_config.yml\r\n--migrations.skip=true --verbose`\r\n\r\nI verify the following on my machine\r\n\r\n**main:**\r\n_1st run:_ 36s\r\n_2nd run:_ 34s\r\n\r\n**this branch:**\r\n_1st run:_ 35s\r\n_2nd run:_ 6s\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e65c6526107670689c520bc20c973626c12c636d"}},{"branch":"7.17","label":"v7.17.9","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->