Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] chore(NA): updates from lmdb-store to lmdb (#145891) #149100

Closed
wants to merge 4 commits into from

Conversation

watson
Copy link
Contributor

@watson watson commented Jan 18, 2023

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/145891","number":145891,"mergeCommit":{"message":"chore(NA): updates from lmdb-store to lmdb (#145891)\n\nThis PR upgrades from `lbmd-store` into `lmdb` which is the new package\r\nand fully compatible with node `v18`.\r\nSo far my tests shows the new implementation is compatible with our\r\nusages and I'm actually seeing a great performance boost when comparing\r\nwith main specially on subsequent calls of the same command.\r\n\r\nThis can be tested by running the following 2 times on main vs this\r\nbranch `time node scripts/kibana --config\r\nsrc/cli/serve/integration_tests/__fixtures__/invalid_config.yml\r\n--migrations.skip=true --verbose`\r\n\r\nI verify the following on my machine\r\n\r\n**main:**\r\n_1st run:_ 36s\r\n_2nd run:_ 34s\r\n\r\n**this branch:**\r\n_1st run:_ 35s\r\n_2nd run:_ 6s\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"e65c6526107670689c520bc20c973626c12c636d"}},{"branch":"7.17","label":"v7.17.9","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->

This PR upgrades from `lbmd-store` into `lmdb` which is the new package
and fully compatible with node `v18`.
So far my tests shows the new implementation is compatible with our
usages and I'm actually seeing a great performance boost when comparing
with main specially on subsequent calls of the same command.

This can be tested by running the following 2 times on main vs this
branch `time node scripts/kibana --config
src/cli/serve/integration_tests/__fixtures__/invalid_config.yml
--migrations.skip=true --verbose`

I verify the following on my machine

**main:**
_1st run:_ 36s
_2nd run:_ 34s

**this branch:**
_1st run:_ 35s
_2nd run:_ 6s

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit e65c652)

# Conflicts:
#	package.json
#	packages/kbn-optimizer/BUILD.bazel
#	packages/kbn-optimizer/src/node/cache.ts
#	packages/kbn-optimizer/src/node/node_auto_tranpilation.ts
#	yarn.lock
@watson
Copy link
Contributor Author

watson commented Jan 18, 2023

@mistic I went ahead and tried to backport #145891 to 7.17 in this PR so we can upgrade its Node.js to version 18. I've looked at the single Jest test failure for hours now and I can't figure out why it's behaving like it does. It's not the jest test itself but rather something with the module system, potentially in combination with jest overriding some things inside the module module (maybe we need to upgrade jest as well??). Would you be able to take a look soon to see if you can figure out what's wrong?

@mistic
Copy link
Member

mistic commented Jan 18, 2023

@watson I found this comment I left back then #146647 (comment)

I think to backport this into 7.17 we will need to upgrade first jest@27 in this branch

@watson
Copy link
Contributor Author

watson commented Jan 18, 2023

@mistic how much work do you think upgrading to jest 27 would be? Unfortunately we do need to upgrade the Node.js version on 7.17 as the current version (v16) will no longer receive any bug or security fixes after 2023-09-11

@mistic
Copy link
Member

mistic commented Jan 18, 2023

@jbudz as you were the one working on this, do you anticipate too much work to upgrade jest to v27 on 7.17?

@kibana-ci
Copy link
Collaborator

kibana-ci commented Feb 14, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@mistic
Copy link
Member

mistic commented Feb 15, 2023

Closing in exchange of #146647

@mistic mistic closed this Feb 15, 2023
auto-merge was automatically disabled February 15, 2023 00:39

Pull request was closed

@watson watson deleted the backport/7.17/pr-145891 branch February 15, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants