Skip to content

[Fleet] Implement subcategories in integrations UI #148894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 19, 2023
Merged

[Fleet] Implement subcategories in integrations UI #148894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
432e6c6
[Fleet] Start implementation of new subcategory UI
criamico Jan 12, 2023
07d3f42
Build basic subcategories row
criamico Jan 13, 2023
1241d82
Implement filtering of packages by selected subcategory
criamico Jan 13, 2023
9ac3401
Refactoring
criamico Jan 16, 2023
1062e14
Available packages refactoring
criamico Jan 16, 2023
b3885cc
Refactor installed packages component
criamico Jan 17, 2023
d4b810b
Fix checks and linter
criamico Jan 17, 2023
9592b1a
Implement subcategory button and add feature flag
criamico Jan 17, 2023
3295dbf
Merge branch 'main' into subcategory_ui
criamico Jan 17, 2023
5005ad9
Merge branch 'main' into subcategory_ui
kibanamachine Jan 18, 2023
cb717f7
Improve handling of subcategories
criamico Jan 18, 2023
7b2946f
Remove sticky menu logic and implement it with css
criamico Jan 18, 2023
9d2f603
Fix cypress test and subcategory url reading
criamico Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/plugins/fleet/common/experimental_features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export const allowedExperimentalValues = Object.freeze({
showDevtoolsRequest: true,
diagnosticFileUploadEnabled: false,
experimentalDataStreamSettings: false,
showIntegrationsSubcategories: false,
});

type ExperimentalConfigKeys = Array<keyof ExperimentalFeatures>;
Expand Down
2 changes: 2 additions & 0 deletions x-pack/plugins/fleet/common/types/models/epm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,8 @@ export interface CategorySummaryItem {
id: CategoryId;
title: string;
count: number;
parent_id?: string;
parent_title?: string;
}

export type RequirementsByServiceName = PackageSpecManifest['conditions'];
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/fleet/cypress/e2e/integrations_real.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ describe('Add Integration - Real API', () => {

it('should filter integrations by category', () => {
setupIntegrations();
cy.getBySel(getIntegrationCategories('aws')).click();
cy.getBySel(getIntegrationCategories('aws')).click({ scrollBehavior: false });

cy.getBySel(INTEGRATIONS_SEARCHBAR.BADGE).contains('AWS').should('exist');
cy.getBySel(INTEGRATION_LIST).find('.euiCard').should('have.length.greaterThan', 29);

Expand Down
14 changes: 10 additions & 4 deletions ...et/public/applications/integrations/sections/epm/components/package_list_grid.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,13 @@ const categories = [
export const EmptyList = (props: Args) => (
<PackageListGrid
list={[]}
onSearchChange={action('onSearchChange')}
setSelectedCategory={action('setSelectedCategory')}
searchTerm=""
setSearchTerm={action('setSearchTerm')}
setCategory={action('setCategory')}
categories={categories}
selectedCategory=""
setUrlandReplaceHistory={action('setUrlandReplaceHistory')}
setUrlandPushHistory={action('setUrlandPushHistory')}
{...props}
/>
);
Expand Down Expand Up @@ -129,10 +132,13 @@ export const List = (props: Args) => (
categories: ['category_two'],
},
]}
onSearchChange={action('onSearchChange')}
setSelectedCategory={action('setSelectedCategory')}
searchTerm=""
setSearchTerm={action('setSearchTerm')}
setCategory={action('setCategory')}
categories={categories}
selectedCategory=""
setUrlandReplaceHistory={action('setUrlandReplaceHistory')}
setUrlandPushHistory={action('setUrlandPushHistory')}
{...props}
/>
);
Expand Down
Loading