Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tracks tutorial to support Agent #143414

Merged
merged 13 commits into from
Nov 16, 2022
Merged

Updated tracks tutorial to support Agent #143414

merged 13 commits into from
Nov 16, 2022

Conversation

jamesagarside
Copy link
Contributor

@jamesagarside jamesagarside commented Oct 15, 2022 •
edited by kibanamachine
Loading

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@jamesagarside jamesagarside added release_note:skip Skip the PR/issue when compiling release notes docs v8.3.0 v8.4.0 v8.5.0 labels Oct 15, 2022
@github-actions
Copy link
Contributor

Documentation preview:

@nickpeihl nickpeihl added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Oct 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@jamesagarside jamesagarside enabled auto-merge (squash) October 15, 2022 12:30
gchaps
gchaps reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this tutorial! A few minor comments.

jamesagarside and others added 8 commits October 19, 2022 18:21
@jamesagarside @gchaps
Update docs/maps/asset-tracking-tutorial.asciidoc
3a86d34 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jamesagarside @gchaps
Update docs/maps/asset-tracking-tutorial.asciidoc
09d3881 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jamesagarside @gchaps
Update docs/maps/asset-tracking-tutorial.asciidoc
ced8e6e 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jamesagarside @gchaps
Update docs/maps/asset-tracking-tutorial.asciidoc
37d6bdd 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jamesagarside @gchaps
Update docs/maps/asset-tracking-tutorial.asciidoc
8b3db17 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jamesagarside @gchaps
Update docs/maps/asset-tracking-tutorial.asciidoc
9fb7a6a 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jamesagarside @gchaps
Update docs/maps/asset-tracking-tutorial.asciidoc
46ca7e6 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jamesagarside @gchaps
Update docs/maps/asset-tracking-tutorial.asciidoc
7a84025 
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@jamesagarside
Copy link
Contributor Author

Hi @gchaps,

Thanks for the corrections, I wasnt sure if Agent was a var or not, now I know :D

Good to merge from my side

nreese
nreese reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting together this PR. I was not aware elastic agent could be used to pull from REST APIs

nickpeihl
nickpeihl reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone new to Fleet and Integrations, I had some trouble getting this to work correctly. Perhaps I did something wrong.

The agent logs first reported that the API key for elastic/fleet-userwas not unauthorized for indices.auto_create. So I manually created the datastream in Kibana Console.

Then the logs reported that the API key for the fleet user was unauthorized for [indices.bulk_action.](indices:data/write/bulk[s]). And now I'm at a loss for why that is?

I attempted this on v8.4.3 in Elastic Cloud.

jlind23
jlind23 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from an elastic agent perspective

jamesagarside
jamesagarside commented Nov 16, 2022
View reviewed changes
Copy link
Contributor Author

@jamesagarside jamesagarside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to add create agent policy if not one exists

@jamesagarside
Copy link
Contributor Author

My apologies for not getting this closed sooner, Thank you for all your help, everything seems good now.

@jamesagarside
Copy link
Contributor Author

@elasticmachine merge upstream

@jamesagarside jamesagarside merged commit b589297 into main Nov 16, 2022
@jamesagarside jamesagarside deleted the update-track-tutorial branch November 16, 2022 21:15
@gchaps gchaps added the v8.6.0 label Nov 16, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 16, 2022
@jamesagarside
Updated tracks tutorial to support Agent (elastic#143414)
1e15b84 
* Updated for Human readable dataview names

* Updated tutorial to support Elastic Agent

(cherry picked from commit b589297)
@kibanamachine kibanamachine mentioned this pull request Nov 16, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 16, 2022
@jamesagarside
Updated tracks tutorial to support Agent (elastic#143414)
15807a6 
* Updated for Human readable dataview names

* Updated tutorial to support Elastic Agent

(cherry picked from commit b589297)
@kibanamachine kibanamachine mentioned this pull request Nov 16, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 16, 2022
@jamesagarside
Updated tracks tutorial to support Agent (elastic#143414)
4f70048 
* Updated for Human readable dataview names

* Updated tutorial to support Elastic Agent

(cherry picked from commit b589297)
This was referenced Nov 16, 2022
Merged
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 16, 2022
@jamesagarside
Updated tracks tutorial to support Agent (elastic#143414)
023104c 
* Updated for Human readable dataview names

* Updated tutorial to support Elastic Agent

(cherry picked from commit b589297)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3
✅ 8.4
✅ 8.5
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 16, 2022
@kibanamachine @jamesagarside
[8.6] Updated tracks tutorial to support Agent (#143414) (#145458)
d378bd3 
# Backport

This will backport the following commits from `main` to `8.6`:
- [Updated tracks tutorial to support Agent
(#143414)](#143414)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Garside","email":"james@jgarside.co.uk"},"sourceCommit":{"committedDate":"2022-11-16T21:15:55Z","message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["[Deprecated-Use
Team:Presentation]Team:Geo","release_note:skip","docs","v8.3.0","v8.4.0","v8.5.0","v8.7.0"],"number":143414,"url":"https://github.com/elastic/kibana/pull/143414","mergeCommit":{"message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.3","8.4","8.5"],"targetPullRequestStates":[{"branch":"8.3","label":"v8.3.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.4","label":"v8.4.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/143414","number":143414,"mergeCommit":{"message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb"}}]}] BACKPORT-->

Co-authored-by: James Garside <james@jgarside.co.uk>
kibanamachine added a commit that referenced this pull request Nov 16, 2022
@kibanamachine @jamesagarside
[8.4] Updated tracks tutorial to support Agent (#143414) (#145456)
0a25691 
# Backport

This will backport the following commits from `main` to `8.4`:
- [Updated tracks tutorial to support Agent
(#143414)](#143414)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Garside","email":"james@jgarside.co.uk"},"sourceCommit":{"committedDate":"2022-11-16T21:15:55Z","message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["[Deprecated-Use
Team:Presentation]Team:Geo","release_note:skip","docs","v8.3.0","v8.4.0","v8.5.0","v8.7.0"],"number":143414,"url":"https://github.com/elastic/kibana/pull/143414","mergeCommit":{"message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.3","8.4","8.5"],"targetPullRequestStates":[{"branch":"8.3","label":"v8.3.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.4","label":"v8.4.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/143414","number":143414,"mergeCommit":{"message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb"}}]}] BACKPORT-->

Co-authored-by: James Garside <james@jgarside.co.uk>
kibanamachine added a commit that referenced this pull request Nov 16, 2022
@kibanamachine @jamesagarside
[8.3] Updated tracks tutorial to support Agent (#143414) (#145455)
a4aad95 
# Backport

This will backport the following commits from `main` to `8.3`:
- [Updated tracks tutorial to support Agent
(#143414)](#143414)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Garside","email":"james@jgarside.co.uk"},"sourceCommit":{"committedDate":"2022-11-16T21:15:55Z","message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["[Deprecated-Use
Team:Presentation]Team:Geo","release_note:skip","docs","v8.3.0","v8.4.0","v8.5.0","v8.7.0"],"number":143414,"url":"https://github.com/elastic/kibana/pull/143414","mergeCommit":{"message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.3","8.4","8.5"],"targetPullRequestStates":[{"branch":"8.3","label":"v8.3.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.4","label":"v8.4.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/143414","number":143414,"mergeCommit":{"message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb"}}]}] BACKPORT-->

Co-authored-by: James Garside <james@jgarside.co.uk>
kibanamachine added a commit that referenced this pull request Nov 16, 2022
@kibanamachine @jamesagarside
[8.5] Updated tracks tutorial to support Agent (#143414) (#145457)
5e9a46c 
# Backport

This will backport the following commits from `main` to `8.5`:
- [Updated tracks tutorial to support Agent
(#143414)](#143414)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Garside","email":"james@jgarside.co.uk"},"sourceCommit":{"committedDate":"2022-11-16T21:15:55Z","message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["[Deprecated-Use
Team:Presentation]Team:Geo","release_note:skip","docs","v8.3.0","v8.4.0","v8.5.0","v8.7.0"],"number":143414,"url":"https://github.com/elastic/kibana/pull/143414","mergeCommit":{"message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb"}},"sourceBranch":"main","suggestedTargetBranches":["8.3","8.4","8.5"],"targetPullRequestStates":[{"branch":"8.3","label":"v8.3.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.4","label":"v8.4.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/143414","number":143414,"mergeCommit":{"message":"Updated
tracks tutorial to support Agent (#143414)\n\n* Updated for Human
readable dataview names\r\n\r\n* Updated tutorial to support Elastic
Agent","sha":"b589297beef876dc84469c7fe328a3849e46d7cb"}}]}] BACKPORT-->

Co-authored-by: James Garside <james@jgarside.co.uk>
@sophiec20 sophiec20 added Feature:Maps and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese left review comments

@nickpeihl nickpeihl nickpeihl left review comments

@gchaps gchaps gchaps left review comments

@jlind23 jlind23 jlind23 approved these changes

Assignees
No one assigned
Labels
docs Feature:Maps release_note:skip Skip the PR/issue when compiling release notes v8.3.0 v8.3.4 v8.4.0 v8.4.4 v8.5.0 v8.5.2 v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jamesagarside @elasticmachine @kibanamachine @nreese @nickpeihl @gchaps @jlind23 @sophiec20