[Terminal Output] tty toggle now shows number of bytes in tooltip, if no output we disa… #141174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2022 14:52
…ble button (instead of hide)
mitodrummer
added
release_note:skip
Co-authored-by: Tyler Smalley <tylersmalley@gmail.com>
opauloh
added
the
Team: AWP: Visualization
opauloh
reviewed
Sep 20, 2022
x-pack/plugins/session_view/public/components/session_view/index.tsx
Outdated
Show resolved
Hide resolved
…a into tty_toggle_improvement
Co-authored-by: Tyler Smalley <tylersmalley@gmail.com>
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ble button (instead of hide)
Summary
Improves the tooltip for TTY toggle. Shows amount of bytes/kb/mb of output data in the toggle button tooltip.
Also using disabled state to show that session has no output (instead of hiding the button altogether).
Checklist
Delete any items that are not applicable to this PR.