Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Annotations design review #140588

Merged
merged 17 commits into from
Sep 19, 2022
Merged

[Lens] Annotations design review #140588

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
208b29a
feedback from Michael p1
mbondyra Sep 13, 2022
12b51c8
Update src/plugins/chart_expressions/expression_xy/public/components/…
mbondyra Sep 14, 2022
642b4e0
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Sep 15, 2022
fc21cab
Apply suggestions from code review
mbondyra Sep 15, 2022
75b917b
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Sep 15, 2022
de688e4
feedback
mbondyra Sep 15, 2022
45f3114
Merge branch 'lens/annotation_fixes' of github.com:mbondyra/kibana in…
mbondyra Sep 15, 2022
4904594
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Sep 15, 2022
e225ce2
Merge commit '1d0504f1f688b51469d595447811ea959237aac7' into lens/ann…
mbondyra Sep 19, 2022
879728f
Merge branch 'lens/annotation_fixes' of github.com:mbondyra/kibana in…
mbondyra Sep 19, 2022
f9c942b
Merge commit '140f7207105431272c8d60840a8a0cc254b17124' into lens/ann…
mbondyra Sep 19, 2022
c9d3a62
don't allow to dnd 1 element
mbondyra Sep 19, 2022
f4ef04e
fix types
mbondyra Sep 19, 2022
5e81a3e
Merge commit '269df0168eea0184c90d9a296d177014a27ca9ff' into lens/ann…
mbondyra Sep 19, 2022
6ba1214
Apply suggestions from code review
mbondyra Sep 19, 2022
a7e7aef
more suggestions
mbondyra Sep 19, 2022
3d7b952
linting
mbondyra Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -… 
…-fix'
  • Loading branch information
@kibanamachine
kibanamachine committed Sep 15, 2022
commit 642b4e0f5cd65a3dc7a5562e234c450fa912eeaf
34 changes: 17 additions & 17 deletions ...c/visualizations/xy/xy_config_panel/annotations_config_panel/tooltip_annotation_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function TooltipSection({
<EuiButton
isDisabled
fullWidth
onClick={() => { }}
onClick={() => {}}
className="lnsConfigPanelAnnotations__noFieldsButton"
>
{i18n.translate('xpack.lens.xyChart.annotation.tooltip.noFields', {
Expand All @@ -139,17 +139,17 @@ export function TooltipSection({
)
.map(
(field) =>
({
label: field.displayName,
value: {
type: 'field',
field: field.name,
dataType: field.type,
},
exists: fieldExists(currentExistingField, field.name),
compatible: true,
'data-test-subj': `lnsXY-annotation-tooltip-fieldOption-${field.name}`,
} as FieldOption<FieldOptionValue>)
({
label: field.displayName,
value: {
type: 'field',
field: field.name,
dataType: field.type,
},
exists: fieldExists(currentExistingField, field.name),
compatible: true,
'data-test-subj': `lnsXY-annotation-tooltip-fieldOption-${field.name}`,
} as FieldOption<FieldOptionValue>)
)
.sort((a, b) => a.label.localeCompare(b.label));

Expand Down Expand Up @@ -207,11 +207,11 @@ export function TooltipSection({
selectedOptions={
value
? [
{
label: value,
value: { type: 'field', field: value },
},
]
{
label: value,
value: { type: 'field', field: value },
},
]
: []
}
options={options}
Expand Down